All of lore.kernel.org
 help / color / mirror / Atom feed
From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [MPCore Watchdog]: Convert from misc_dev to dynamic device node.
Date: Wed, 15 Jun 2011 09:58:20 +0100	[thread overview]
Message-ID: <20110615085820.GH3075@pulham.picochip.com> (raw)
In-Reply-To: <BANLkTik02nt4ttTTS-3u5R_ZH0W90FADJQ@mail.gmail.com>

On Tue, Jun 14, 2011 at 05:19:06PM -0700, Peter Fordham wrote:
> > On Tue, Jun 14, 2011 at 04:29:26PM -0700, Peter Fordham wrote:
> >> The current MPCore watchdog driver uses a misc_dev device node.
> >> This patch changes it to use dynamically allocated device numbers.
> >
> > I'm not sure that this is the correct thing to do. ?All other watchdog devices
> > use a miscdevice with a major:minor of 10:130, is there a specific reason
> > that this node needs to be dynamic?
> 
> I was under the impressions that dynamic device nodes were the way of the
> future. Is that not the case?

Well they are for new devices/subsystems but watchdog has an established 
major:minor pair that all other devices use so you don't really have to 
worry about a namespace clash.

> I'll add the relevant checks in other places as per your suggestions.

I've added Wim (watchdog driver maintainer), but I would think that if 
this change is worth doing then it should be done for all drivers.

> > I believe the sysfs classes are pretty much
> > deprecated now in preference of a bus too.
> 
> Can you give me some more info here? I thought the sysfs stuff was the
> new right way of doing stuff. The class stuff allows udev to automatically
> create the right device node.

So here's one that I'm aware of https://lkml.org/lkml/2011/3/25/502.  So 
there's nothing wrong with using sysfs and a bus, but certainly a bus is 
preferred over a class.

Jamie

  reply	other threads:[~2011-06-15  8:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 23:29 [MPCore Watchdog]: Convert from misc_dev to dynamic device node Peter Fordham
2011-06-14 23:48 ` Jamie Iles
2011-06-15  0:19   ` Peter Fordham
2011-06-15  8:58     ` Jamie Iles [this message]
2011-06-15 18:57       ` Peter Fordham
2011-06-15 19:09         ` Jamie Iles
2011-06-15 19:36           ` Peter Fordham
2011-06-15 19:37             ` Peter Fordham
2011-06-15 19:36           ` Arnd Bergmann
2011-06-15 19:49             ` Peter Fordham
2011-06-15 20:03               ` Arnd Bergmann
2011-06-17  7:20             ` Wim Van Sebroeck
2011-06-17  7:20               ` Wim Van Sebroeck
2011-06-17  7:17         ` Wim Van Sebroeck
2011-06-17  7:17           ` Wim Van Sebroeck
2011-06-17  7:14       ` Wim Van Sebroeck
2011-06-17  7:14         ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110615085820.GH3075@pulham.picochip.com \
    --to=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.