All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	yrl.pp-manager.tt@hitachi.com,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Namhyung Kim <namhyung@gmail.com>
Subject: [PATCH 14/16 v2] x86: Swap save_stack_trace_regs parameters
Date: Wed, 15 Jun 2011 09:48:55 -0400	[thread overview]
Message-ID: <20110615135236.272606592@goodmis.org> (raw)
In-Reply-To: 20110615134841.767565350@goodmis.org

[-- Attachment #1: 0014-x86-Swap-save_stack_trace_regs-parameters.patch --]
[-- Type: text/plain, Size: 2359 bytes --]

From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Swap the 1st and 2nd parameters of save_stack_trace_regs()
as same as the parameters of save_stack_trace_tsk().

Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: yrl.pp-manager.tt@hitachi.com
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Namhyung Kim <namhyung@gmail.com>
Link: http://lkml.kernel.org/r/20110608070921.17777.31103.stgit@fedora15
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 arch/x86/kernel/stacktrace.c  |    2 +-
 arch/x86/mm/kmemcheck/error.c |    2 +-
 include/linux/stacktrace.h    |    4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/stacktrace.c b/arch/x86/kernel/stacktrace.c
index 55d9bc0..fdd0c64 100644
--- a/arch/x86/kernel/stacktrace.c
+++ b/arch/x86/kernel/stacktrace.c
@@ -66,7 +66,7 @@ void save_stack_trace(struct stack_trace *trace)
 }
 EXPORT_SYMBOL_GPL(save_stack_trace);
 
-void save_stack_trace_regs(struct stack_trace *trace, struct pt_regs *regs)
+void save_stack_trace_regs(struct pt_regs *regs, struct stack_trace *trace)
 {
 	dump_trace(current, regs, NULL, 0, &save_stack_ops, trace);
 	if (trace->nr_entries < trace->max_entries)
diff --git a/arch/x86/mm/kmemcheck/error.c b/arch/x86/mm/kmemcheck/error.c
index 704a37c..dab4187 100644
--- a/arch/x86/mm/kmemcheck/error.c
+++ b/arch/x86/mm/kmemcheck/error.c
@@ -185,7 +185,7 @@ void kmemcheck_error_save(enum kmemcheck_shadow state,
 	e->trace.entries = e->trace_entries;
 	e->trace.max_entries = ARRAY_SIZE(e->trace_entries);
 	e->trace.skip = 0;
-	save_stack_trace_regs(&e->trace, regs);
+	save_stack_trace_regs(regs, &e->trace);
 
 	/* Round address down to nearest 16 bytes */
 	shadow_copy = kmemcheck_shadow_lookup(address
diff --git a/include/linux/stacktrace.h b/include/linux/stacktrace.h
index 25310f1..115b570 100644
--- a/include/linux/stacktrace.h
+++ b/include/linux/stacktrace.h
@@ -14,8 +14,8 @@ struct stack_trace {
 };
 
 extern void save_stack_trace(struct stack_trace *trace);
-extern void save_stack_trace_regs(struct stack_trace *trace,
-				  struct pt_regs *regs);
+extern void save_stack_trace_regs(struct pt_regs *regs,
+				  struct stack_trace *trace);
 extern void save_stack_trace_tsk(struct task_struct *tsk,
 				struct stack_trace *trace);
 
-- 
1.7.4.4



  parent reply	other threads:[~2011-06-15 13:53 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15 13:48 [PATCH 00/16 v2] [GIT PULL] tracing: various fixes Steven Rostedt
2011-06-15 13:48 ` [PATCH 01/16 v2] tracing: Schedule a delayed work to call wakeup() Steven Rostedt
2011-06-15 13:48 ` [PATCH 02/16 v2] tracing: Use NUMA allocation for per-cpu ring buffer pages Steven Rostedt
2011-06-15 13:48 ` [PATCH 03/16 v2] tracing: Add a proc file to stop tracing and free buffer Steven Rostedt
2011-06-15 14:25   ` Frederic Weisbecker
2011-06-15 14:43     ` Steven Rostedt
2011-06-15 14:45       ` Frederic Weisbecker
2011-06-15 13:48 ` [PATCH 04/16 v2] tracing: Add disable_on_free option Steven Rostedt
2011-06-15 13:48 ` [PATCH 05/16 v2] ftrace: Fixed an include coding style issue Steven Rostedt
2011-06-15 13:48 ` [PATCH 06/16 v2] async: " Steven Rostedt
2011-06-15 13:48 ` [PATCH 07/16 v2] tracing, function_graph: Remove dependency of abstime and duration Steven Rostedt
2011-06-15 13:48 ` [PATCH 08/16 v2] tracing, function_graph: Merge overhead and duration display Steven Rostedt
2011-06-15 13:48 ` [PATCH 09/16 v2] tracing, function: Fix trace header to follow context-info option Steven Rostedt
2011-06-15 13:48 ` [PATCH 10/16 v2] tracing, function_graph: Remove lock-depth from latency trace Steven Rostedt
2011-06-15 13:48 ` [PATCH 11/16 v2] tracing, function_graph: Add context-info support for function_graph Steven Rostedt
2011-06-15 13:48 ` [PATCH 12/16 v2] tracing: Convert to kstrtoul_from_user Steven Rostedt
2011-06-15 13:48 ` [PATCH 13/16 v2] ring-buffer: Set __GFP_NORETRY flag for ring buffer allocating Steven Rostedt
2011-06-15 13:48 ` Steven Rostedt [this message]
2011-06-15 13:48 ` [PATCH 15/16 v2] stack_trace: Add weak save_stack_trace_regs() Steven Rostedt
2011-06-15 13:48 ` [PATCH 16/16 v2] tracing/kprobes: Fix kprobe-tracer to support stack trace Steven Rostedt
2011-06-16 14:00 ` [PATCH 00/16 v2] [GIT PULL] tracing: various fixes Ingo Molnar
2011-06-28 19:48   ` Steven Rostedt
2011-07-01 12:44     ` Ingo Molnar
2011-07-01 13:11       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110615135236.272606592@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@elte.hu \
    --cc=namhyung@gmail.com \
    --cc=yrl.pp-manager.tt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.