All of lore.kernel.org
 help / color / mirror / Atom feed
From: Solar Designer <solar@openwall.com>
To: kernel-hardening@lists.openwall.com
Subject: Re: [kernel-hardening] [RFC 2/5 v3] procfs: add hidepid= and gid= mount options
Date: Wed, 15 Jun 2011 18:22:44 +0400	[thread overview]
Message-ID: <20110615142244.GA32753@openwall.com> (raw)
In-Reply-To: <1308146286-12840-1-git-send-email-segoon@openwall.com>

Vasiliy,

On Wed, Jun 15, 2011 at 05:58:05PM +0400, Vasiliy Kulikov wrote:
> +	if (pid->hide_pid &&
> +	    !ptrace_may_access(task, PTRACE_MODE_READ) &&
> +	    !in_group_p(pid->pid_gid)) {

I think ptrace_may_access() involves capable() in some cases (when
access would otherwise be denied).  Thus, in order not to raise the used
privs flag unnecessarily, you need to check it last - after checking
in_group_p().

Thanks,

Alexander

  reply	other threads:[~2011-06-15 14:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15 13:58 [kernel-hardening] [RFC 2/5 v3] procfs: add hidepid= and gid= mount options Vasiliy Kulikov
2011-06-15 13:58 ` Vasiliy Kulikov
2011-06-15 14:22 ` Solar Designer [this message]
2011-06-15 16:51   ` [kernel-hardening] " Vasiliy Kulikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110615142244.GA32753@openwall.com \
    --to=solar@openwall.com \
    --cc=kernel-hardening@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.