From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36563)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcelo@amt.cnet>) id 1QYL0O-00083o-5H
	for qemu-devel@nongnu.org; Sun, 19 Jun 2011 12:37:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcelo@amt.cnet>) id 1QYL0N-0004Yf-Bp
	for qemu-devel@nongnu.org; Sun, 19 Jun 2011 12:37:48 -0400
Received: from [189.114.189.193] (port=48120 helo=amt.cnet)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcelo@amt.cnet>) id 1QYL0M-0004YI-IN
	for qemu-devel@nongnu.org; Sun, 19 Jun 2011 12:37:47 -0400
Date: Wed, 15 Jun 2011 12:49:30 -0300
From: Marcelo Tosatti <mtosatti@redhat.com>
Message-ID: <20110615154930.GA12994@amt.cnet>
References: <20110606165536.581119615@amt.cnet>
	<20110606165823.855959321@amt.cnet>
	<20110606170344.GA30636@amt.cnet>
	<20110607101555.GO514380@orkuz.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110607101555.GO514380@orkuz.home>
Subject: Re: [Qemu-devel] [patch 6/7] QEMU live block copy (update)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jiri Denemark <jdenemar@redhat.com>
Cc: kwolf@redhat.com, Jes.Sorensen@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, avi@redhat.com

On Tue, Jun 07, 2011 at 12:15:55PM +0200, Jiri Denemark wrote:
> > +            }
> > +        },
> 
> What about using the same form of progress reporting as used by query-migrate?
> That is, instead of

Done.

> One can trivially compute percentage from that but it's impossible to get this
> kind of data when only percentage is reported. And total can even change in
> time if needed (just like it changes during migration).
> 
> > +        {"device":"ide1-hd1",
> > +         "status":"failed"
> > +        }
> 
> Is there any way we can get the exact error which made it fail, such as EPERM
> or ENOSPC?

The errors that can generate "failed" here are internal to QEMU, so i
don't think exporting them to management application makes sense. This 
are errors such as EIO from file system.

Error processing should be done in the block_copy command, that is where
checks of the destination image are performed.