From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Antti Julku <antti.julku@nokia.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] Bluetooth: Add blacklisting support for mgmt interface
Date: Thu, 16 Jun 2011 15:21:52 -0300 [thread overview]
Message-ID: <20110616182152.GA2594@joana> (raw)
In-Reply-To: <20110615194849.GA8047@dell.ger.corp.intel.com>
* Johan Hedberg <johan.hedberg@gmail.com> [2011-06-15 22:48:49 +0300]:
> Hi Gustavo,
>
> On Wed, Jun 15, 2011, Gustavo F. Padovan wrote:
> > > +#define MGMT_OP_BLOCK_DEVICE 0x001D
> > > +struct mgmt_cp_block_device {
> > > + bdaddr_t bdaddr;
> > > +} __packed;
> > > +
> > > +#define MGMT_OP_UNBLOCK_DEVICE 0x001E
> >
> > To make hci code consistent call replace _DEVICE by _ADDR in both macros.
>
> I think Antti was just taking example from MGMT_OP_PAIR_DEVICE. To me
> "device" sounds better than "addr" as far as the management interface is
> concerned, but I'm not gonna object if you wanna change these
> occurrences to addr.
Fair enough. Both patches applied. Thanks.
Gustavo
prev parent reply other threads:[~2011-06-16 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 9:01 [PATCH 1/2] Bluetooth: Move blacklisting functions to hci_core Antti Julku
2011-06-15 9:01 ` [PATCH 2/2] Bluetooth: Add blacklisting support for mgmt interface Antti Julku
2011-06-15 17:57 ` Gustavo F. Padovan
2011-06-15 19:48 ` Johan Hedberg
2011-06-16 18:21 ` Gustavo F. Padovan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110616182152.GA2594@joana \
--to=padovan@profusion.mobi \
--cc=antti.julku@nokia.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.