From mboxrd@z Thu Jan  1 00:00:00 1970
From: j.neuschaefer@gmx.net (Jonathan =?utf-8?Q?Neusch=C3=A4fer?=)
Date: Fri, 17 Jun 2011 17:10:14 +0200
Subject: Build scatterlist covering a process' text segment?
In-Reply-To: <4DFAA41D.5010307@enea.com>
References: <4DDAE865.6000608@enea.com> <4DDD663C.4060201@enea.com>
	<BANLkTim_mR5ns1N8J6HudGrwHZKJEBgDug@mail.gmail.com>
	<4DE01E94.8000505@enea.com>
	<BANLkTim3bwXaGXaeXo7D8ZprNUgCw7CK2g@mail.gmail.com>
	<4DFAA41D.5010307@enea.com>
Message-ID: <20110617151014.GB1451@debian.debian>
To: kernelnewbies@lists.kernelnewbies.org
List-Id: kernelnewbies.lists.kernelnewbies.org

On Fri, Jun 17, 2011 at 02:47:25AM +0200, Arvid Brodin wrote:
[...]
> 	/**** User page code ****/
> 
> 	pages = kmalloc(nr_pages * sizeof(*pages), GFP_KERNEL);

kcalloc?

You don't need the zeroing but the overflow check might be useful.

> 	if (!pages) {
> 		retval = -ENOMEM;
> 		goto err_pages;
> 	}

Greetings,
	Jonathan Neusch?fer