All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@ti.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"patches@opensource.wolfsonmicro.com"
	<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: soc-dapm: Fix breakage with incorrect codec pointer
Date: Fri, 17 Jun 2011 17:01:53 +0100	[thread overview]
Message-ID: <20110617160153.GA11241@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4DFB77AA.8060803@ti.com>

On Fri, Jun 17, 2011 at 04:50:02PM +0100, Liam Girdwood wrote:
> On 17/06/11 15:52, Dimitris Papastamos wrote:

> > -		soc_widget_update_bits(w, reg, mask, value);
> > +		snd_soc_update_bits(dapm->codec, reg, mask, value);

> Acked-by: Liam Girdwood <lrg@ti.com>

This'll work just now but it essentially invalidates the change to
support non-CODEC DAPM widgets - we need to fix that change properly,
this means that anything other than a CODEC won't be able to use
registers.

  reply	other threads:[~2011-06-17 16:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-17 14:52 [PATCH] ASoC: soc-dapm: Fix breakage with incorrect codec pointer Dimitris Papastamos
2011-06-17 15:50 ` Liam Girdwood
2011-06-17 16:01   ` Mark Brown [this message]
2011-06-18 14:10     ` Dimitris Papastamos
2011-06-18 14:41       ` Mark Brown
2011-06-19 17:01         ` Dimitris Papastamos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110617160153.GA11241@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.