From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p5K0rPSb095750 for ; Sun, 19 Jun 2011 19:53:25 -0500 Received: from ipmail07.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 743C451EBFA for ; Sun, 19 Jun 2011 17:53:23 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id dKRLJQqULRLGvZj6 for ; Sun, 19 Jun 2011 17:53:23 -0700 (PDT) Date: Mon, 20 Jun 2011 10:53:21 +1000 From: Dave Chinner Subject: Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints Message-ID: <20110620005321.GM561@dastard> References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-2-git-send-email-david@fromorbit.com> <4DFE97F1.2030206@jp.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4DFE97F1.2030206@jp.fujitsu.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: KOSAKI Motohiro Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com T24gTW9uLCBKdW4gMjAsIDIwMTEgYXQgMDk6NDQ6MzNBTSArMDkwMCwgS09TQUtJIE1vdG9oaXJv IHdyb3RlOgo+ICgyMDExLzA2LzAyIDE2OjAwKSwgRGF2ZSBDaGlubmVyIHdyb3RlOgo+ID4gRnJv bTogRGF2ZSBDaGlubmVyIDxkY2hpbm5lckByZWRoYXQuY29tPgo+ID4gCj4gPiDQhnQgaXMgaW1w b3NzaWJsZSB0byB1bmRlcnN0YW5kIHdoYXQgdGhlIHNocmlua2VycyBhcmUgYWN0dWFsbHkgZG9p bmcKPiA+IHdpdGhvdXQgaW5zdHJ1bWVudGluZyB0aGUgY29kZSwgc28gYWRkIGEgc29tZSB0cmFj ZXBvaW50cyB0byBhbGxvdwo+ID4gaW5zaWdodCB0byBiZSBnYWluZWQuCj4gPiAKPiA+IFNpZ25l ZC1vZmYtYnk6IERhdmUgQ2hpbm5lciA8ZGNoaW5uZXJAcmVkaGF0LmNvbT4KPiA+IC0tLQo+ID4g IGluY2x1ZGUvdHJhY2UvZXZlbnRzL3Ztc2Nhbi5oIHwgICA2NyArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKwo+ID4gIG1tL3Ztc2Nhbi5jICAgICAgICAgICAgICAgICAg IHwgICAgNiArKystCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA3MiBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9ucygtKQo+IAo+IFRoaXMgbG9vayBnb29kIHRvIG1lLiBJIGhhdmUgdHdvIG1pbm9yIHJl cXVlc3QuIDEpIHBsZWFzZSBjaGFuZ2UgcGF0Y2ggb3JkZXIsCj4gbW92ZSB0aGlzIHBhdGNoIGFm dGVyIHNocmlua2VyIGNoYW5nZXMuIGlvdywgbm93IGJvdGggdGhpcyBhbmQgWzIvMTJdIGhhdmUK PiB0cmFjZXBvaW50IGNoYW5nZS4gSSBkb24ndCBsaWtlIGl0LgoKTm8gYmlnIGRlYWwgLSBJJ2xs IGp1c3QgZm9sZCB0aGUgc2Vjb25kIGNoYW5nZSAoaG93IHNocmlua2VyLT5uciBpcwpwYXNzZWQg aW50byB0aGUgdHJhY2Vwb2ludCkgaW50byB0aGUgZmlyc3QuIFRyYWNlcG9pbnRzIHNob3VsZCBi ZQpmaXJzdCBpbiB0aGUgc2VyaWVzLCBhbnl3YXksIG90aGVyd2lzZSB0aGVyZSBpcyBubyB3YXkg dG8gdmFsaWRhdGUKdGhlIGJlZm9yZS9hZnRlciBlZmZlY3Qgb2YgdGhlIGJ1ZyBmaXhlcy4uLi4K Cj4gMikgcGxlYXNlIGF2b2lkIGNyeXB0aWMgYWJicmV2aWF0ZWQgdmFyaWFibGUKPiBuYW1lcy4g SW5zdGVhZCwgcGxlYXNlIGp1c3QgdXNlIHRoZSBzYW1lIHZhcmlhYmxlIG5hbWUgd2l0aAo+IHZt c2Nhbi5jIHNvdXJjZSBjb2RlLgoKU28gcmVwbGFjZSBjcnlwdGljIGFiYnJldmlhdGVkIG5hbWVz IHdpdGggc2xpZ2h0bHkgZGlmZmVyZW50CmNyeXB0aWMgYWJicmV2aWF0ZWQgbmFtZXM/IDspCgpT dXJlLCBJIGNhbiBkbyB0aGF0Li4uCgpDaGVlcnMsCgpEYXZlLgotLSAKRGF2ZSBDaGlubmVyCmRh dmlkQGZyb21vcmJpdC5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCnhmcyBtYWlsaW5nIGxpc3QKeGZzQG9zcy5zZ2kuY29tCmh0dHA6Ly9vc3Muc2dp LmNvbS9tYWlsbWFuL2xpc3RpbmZvL3hmcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751871Ab1FTAxZ (ORCPT ); Sun, 19 Jun 2011 20:53:25 -0400 Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:28031 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232Ab1FTAxY (ORCPT ); Sun, 19 Jun 2011 20:53:24 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq0DAIqY/k15LCoegWdsb2JhbABShEmiEhUBARYmJYhzrgePag6BHYN1gQoEmVSIHQ Date: Mon, 20 Jun 2011 10:53:21 +1000 From: Dave Chinner To: KOSAKI Motohiro Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com Subject: Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints Message-ID: <20110620005321.GM561@dastard> References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-2-git-send-email-david@fromorbit.com> <4DFE97F1.2030206@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4DFE97F1.2030206@jp.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2011 at 09:44:33AM +0900, KOSAKI Motohiro wrote: > (2011/06/02 16:00), Dave Chinner wrote: > > From: Dave Chinner > > > > Іt is impossible to understand what the shrinkers are actually doing > > without instrumenting the code, so add a some tracepoints to allow > > insight to be gained. > > > > Signed-off-by: Dave Chinner > > --- > > include/trace/events/vmscan.h | 67 +++++++++++++++++++++++++++++++++++++++++ > > mm/vmscan.c | 6 +++- > > 2 files changed, 72 insertions(+), 1 deletions(-) > > This look good to me. I have two minor request. 1) please change patch order, > move this patch after shrinker changes. iow, now both this and [2/12] have > tracepoint change. I don't like it. No big deal - I'll just fold the second change (how shrinker->nr is passed into the tracepoint) into the first. Tracepoints should be first in the series, anyway, otherwise there is no way to validate the before/after effect of the bug fixes.... > 2) please avoid cryptic abbreviated variable > names. Instead, please just use the same variable name with > vmscan.c source code. So replace cryptic abbreviated names with slightly different cryptic abbreviated names? ;) Sure, I can do that... Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints Date: Mon, 20 Jun 2011 10:53:21 +1000 Message-ID: <20110620005321.GM561@dastard> References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-2-git-send-email-david@fromorbit.com> <4DFE97F1.2030206@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com To: KOSAKI Motohiro Return-path: Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:28031 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751232Ab1FTAxY (ORCPT ); Sun, 19 Jun 2011 20:53:24 -0400 Content-Disposition: inline In-Reply-To: <4DFE97F1.2030206@jp.fujitsu.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jun 20, 2011 at 09:44:33AM +0900, KOSAKI Motohiro wrote: > (2011/06/02 16:00), Dave Chinner wrote: > > From: Dave Chinner > >=20 > > =D0=86t is impossible to understand what the shrinkers are actually= doing > > without instrumenting the code, so add a some tracepoints to allow > > insight to be gained. > >=20 > > Signed-off-by: Dave Chinner > > --- > > include/trace/events/vmscan.h | 67 +++++++++++++++++++++++++++++= ++++++++++++ > > mm/vmscan.c | 6 +++- > > 2 files changed, 72 insertions(+), 1 deletions(-) >=20 > This look good to me. I have two minor request. 1) please change patc= h order, > move this patch after shrinker changes. iow, now both this and [2/12]= have > tracepoint change. I don't like it. No big deal - I'll just fold the second change (how shrinker->nr is passed into the tracepoint) into the first. Tracepoints should be first in the series, anyway, otherwise there is no way to validate the before/after effect of the bug fixes.... > 2) please avoid cryptic abbreviated variable > names. Instead, please just use the same variable name with > vmscan.c source code. So replace cryptic abbreviated names with slightly different cryptic abbreviated names? ;) Sure, I can do that... Cheers, Dave. --=20 Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id C927E6B0012 for ; Sun, 19 Jun 2011 20:53:25 -0400 (EDT) Date: Mon, 20 Jun 2011 10:53:21 +1000 From: Dave Chinner Subject: Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints Message-ID: <20110620005321.GM561@dastard> References: <1306998067-27659-1-git-send-email-david@fromorbit.com> <1306998067-27659-2-git-send-email-david@fromorbit.com> <4DFE97F1.2030206@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4DFE97F1.2030206@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: KOSAKI Motohiro Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xfs@oss.sgi.com On Mon, Jun 20, 2011 at 09:44:33AM +0900, KOSAKI Motohiro wrote: > (2011/06/02 16:00), Dave Chinner wrote: > > From: Dave Chinner > > > > D?t is impossible to understand what the shrinkers are actually doing > > without instrumenting the code, so add a some tracepoints to allow > > insight to be gained. > > > > Signed-off-by: Dave Chinner > > --- > > include/trace/events/vmscan.h | 67 +++++++++++++++++++++++++++++++++++++++++ > > mm/vmscan.c | 6 +++- > > 2 files changed, 72 insertions(+), 1 deletions(-) > > This look good to me. I have two minor request. 1) please change patch order, > move this patch after shrinker changes. iow, now both this and [2/12] have > tracepoint change. I don't like it. No big deal - I'll just fold the second change (how shrinker->nr is passed into the tracepoint) into the first. Tracepoints should be first in the series, anyway, otherwise there is no way to validate the before/after effect of the bug fixes.... > 2) please avoid cryptic abbreviated variable > names. Instead, please just use the same variable name with > vmscan.c source code. So replace cryptic abbreviated names with slightly different cryptic abbreviated names? ;) Sure, I can do that... Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org