From: Arnd Bergmann <arnd@arndb.de>
To: Zhangfei Gao <zhangfei.gao@marvell.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3
Date: Mon, 20 Jun 2011 10:07:33 +0200 [thread overview]
Message-ID: <201106201007.33908.arnd@arndb.de> (raw)
In-Reply-To: <1308552287-18752-1-git-send-email-zhangfei.gao@marvell.com>
On Monday 20 June 2011 08:44:47 Zhangfei Gao wrote:
> Without depends, MMC_SDHCI_PXAV3/2 can be chosen in other platfrom.
> Build error will occur since plat/sdhci.h is located at arch/arm/plat-pxa/
>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@marvell.com>
> ---
> drivers/mmc/host/Kconfig | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 198ddda..d33a3e2 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -183,6 +183,7 @@ config MMC_SDHCI_S3C
>
> config MMC_SDHCI_PXAV3
> tristate "Marvell MMP2 SD Host Controller support (PXAV3)"
> + depends on ARCH_MMP
> select MMC_SDHCI
> select MMC_SDHCI_PLTFM
> default CPU_MMP2
Why not just move the header file to include/linux/platform_data/?
Then you can build the driver on all platforms, which improves the
build test coverage.
Arnd
next prev parent reply other threads:[~2011-06-20 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 6:44 [PATCH] mmc: add dependence in Kconfig for pxav2/pxav3 Zhangfei Gao
2011-06-20 8:07 ` Arnd Bergmann [this message]
2011-06-20 9:36 ` zhangfei gao
2011-06-20 10:02 ` zhangfei gao
2011-06-20 10:26 ` zhangfei gao
2011-06-20 11:49 ` Arnd Bergmann
2011-06-20 13:23 ` zhangfei gao
2011-06-20 13:25 ` Arnd Bergmann
2011-06-20 11:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106201007.33908.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=zhangfei.gao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.