diff for duplicates of <20110620102705.GC31864@opensource.wolfsonmicro.com> diff --git a/a/1.txt b/N1/1.txt index 3c55472..846bfde 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ On Mon, Jun 20, 2011 at 03:26:08PM +0900, MyungJoo Ham wrote: > On Sun, Jun 19, 2011 at 12:12 AM, Mark Brown > >> +static struct regulator_consumer_supply nuri_max8997_ldo1_consumer[] = { -> >> + ? ? REGULATOR_SUPPLY("vadc", NULL), /* Used by CPU's ADC drv */ +> >> + REGULATOR_SUPPLY("vadc", NULL), /* Used by CPU's ADC drv */ > >> +}; > > In the ADC regulator patch you called the supply vdd (though the chip @@ -25,13 +25,13 @@ to use. > >> +static void __init nuri_pmic_init(void) > >> +{ -> >> + ? ? int gpio; +> >> + int gpio; > >> + -> >> + ? ? nuri_max8997_pdata.irq_base = irq_get_next_irq(IRQ_GPIO_END); -> >> + ? ? gpio = NURI_PMIC_GPIO; -> >> + ? ? gpio_request(gpio, "AP_PMIC_IRQ"); -> >> + ? ? s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(0xf)); -> >> + ? ? s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE); +> >> + nuri_max8997_pdata.irq_base = irq_get_next_irq(IRQ_GPIO_END); +> >> + gpio = NURI_PMIC_GPIO; +> >> + gpio_request(gpio, "AP_PMIC_IRQ"); +> >> + s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(0xf)); +> >> + s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE); > >> +} > > I'm not sure both the #define and the variable make sense here... diff --git a/a/content_digest b/N1/content_digest index a74f5ca..c1a2e8d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,17 +1,23 @@ "ref\01308215372-17420-1-git-send-email-myungjoo.ham@samsung.com\0" "ref\020110618151227.GB25163@sirena.org.uk\0" "ref\0BANLkTiniwMCW-ED4CX=qybMvk243Zdki4Q@mail.gmail.com\0" - "From\0broonie@opensource.wolfsonmicro.com (Mark Brown)\0" - "Subject\0[PATCH 1/2] Exynos4 NURI: configure regulators and PMIC\0" + "From\0Mark Brown <broonie@opensource.wolfsonmicro.com>\0" + "Subject\0Re: [PATCH 1/2] Exynos4 NURI: configure regulators and PMIC\0" "Date\0Mon, 20 Jun 2011 11:27:05 +0100\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0myungjoo.ham@gmail.com\0" + "Cc\0linux-arm-kernel@lists.infradead.org" + Kukjin Kim <kgene.kim@samsung.com> + Russell King <linux@arm.linux.org.uk> + linux-kernel@vger.kernel.org + dg77.kim@samsung.com + " kyungmin.park@samsung.com\0" "\00:1\0" "b\0" "On Mon, Jun 20, 2011 at 03:26:08PM +0900, MyungJoo Ham wrote:\n" "> On Sun, Jun 19, 2011 at 12:12 AM, Mark Brown\n" "\n" "> >> +static struct regulator_consumer_supply nuri_max8997_ldo1_consumer[] = {\n" - "> >> + ? ? REGULATOR_SUPPLY(\"vadc\", NULL), /* Used by CPU's ADC drv */\n" + "> >> + \302\240 \302\240 REGULATOR_SUPPLY(\"vadc\", NULL), /* Used by CPU's ADC drv */\n" "> >> +};\n" "\n" "> > In the ADC regulator patch you called the supply vdd (though the chip\n" @@ -34,13 +40,13 @@ "\n" "> >> +static void __init nuri_pmic_init(void)\n" "> >> +{\n" - "> >> + ? ? int gpio;\n" + "> >> + \302\240 \302\240 int gpio;\n" "> >> +\n" - "> >> + ? ? nuri_max8997_pdata.irq_base = irq_get_next_irq(IRQ_GPIO_END);\n" - "> >> + ? ? gpio = NURI_PMIC_GPIO;\n" - "> >> + ? ? gpio_request(gpio, \"AP_PMIC_IRQ\");\n" - "> >> + ? ? s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(0xf));\n" - "> >> + ? ? s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);\n" + "> >> + \302\240 \302\240 nuri_max8997_pdata.irq_base = irq_get_next_irq(IRQ_GPIO_END);\n" + "> >> + \302\240 \302\240 gpio = NURI_PMIC_GPIO;\n" + "> >> + \302\240 \302\240 gpio_request(gpio, \"AP_PMIC_IRQ\");\n" + "> >> + \302\240 \302\240 s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(0xf));\n" + "> >> + \302\240 \302\240 s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);\n" "> >> +}\n" "\n" "> > I'm not sure both the #define and the variable make sense here...\n" @@ -52,4 +58,4 @@ "everywhere or use the variable everywhere but having both seems\n" excessive. -f8ff5b763ba1577ed23bc2f0ae4fbb40e55ff0822a13b6f558c5a35aee41383d +d399fbdc58f55d9e647ab69d16a93f48588aa1af1a13076d24c816d7ff619b38
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.