From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: alsa-devel@alsa-project.org, jassisinghbrar@gmail.com,
lrg@slimlogic.co.uk
Subject: Re: [PATCH V3 1/4] ASoC: SAMSUNG: Move I2S common register definition
Date: Mon, 20 Jun 2011 11:32:32 +0100 [thread overview]
Message-ID: <20110620103232.GE31864@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1308555381-4419-1-git-send-email-sbkim73@samsung.com>
On Mon, Jun 20, 2011 at 04:36:18PM +0900, Sangbeom Kim wrote:
> +#define I2SCON 0x0
> +#define I2SMOD 0x4
> +#define I2SFIC 0x8
> +#define I2SPSR 0xc
> +#define I2STXD 0x10
> +#define I2SRXD 0x14
> +#define I2SFICS 0x18
> +#define I2STXDS 0x1c
It'd be better to namespace things in header files, though if the header
is only included in a single driver it doesn't really matter so much.
next prev parent reply other threads:[~2011-06-20 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 7:36 [PATCH V3 1/4] ASoC: SAMSUNG: Move I2S common register definition Sangbeom Kim
2011-06-20 7:36 ` [PATCH V3 2/4] ASoC: SAMSUNG: Add idma related " Sangbeom Kim
2011-06-26 7:20 ` Jassi Brar
2011-06-26 11:05 ` Mark Brown
2011-06-20 7:36 ` [PATCH V3 3/4] ASoC: SAMSUNG: Modify I2S driver to support idma Sangbeom Kim
2011-06-26 8:57 ` Jassi Brar
2011-06-20 7:36 ` [PATCH V3 4/4] ASoC: SAMSUNG: Add I2S0 internal dma driver Sangbeom Kim
2011-06-26 11:08 ` Jassi Brar
2011-06-20 10:32 ` Mark Brown [this message]
2011-06-26 7:14 ` [PATCH V3 1/4] ASoC: SAMSUNG: Move I2S common register definition Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620103232.GE31864@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jassisinghbrar@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.