From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Arik Nemtsov <arik@wizery.com>,
linux-wireless@vger.kernel.org, Kalle Valo <kvalo@adurom.com>
Subject: Re: [RFC] mac80211: dynamic PS - don't enter PS when TX frames are pending
Date: Mon, 20 Jun 2011 09:35:35 -0400 [thread overview]
Message-ID: <20110620133535.GA2251@tuxdriver.com> (raw)
In-Reply-To: <1308471076.4145.6.camel@jlt3.sipsolutions.net>
On Sun, Jun 19, 2011 at 10:11:16AM +0200, Johannes Berg wrote:
> On Sat, 2011-06-18 at 22:32 +0300, Arik Nemtsov wrote:
> > Use the tx_frames_pending() driver callback to determine if Tx frames are
> > pending for its internal queues. If so postpone the dynamic PS timeout
> > to avoid interrupting Tx traffic.
> >
> > The commit e8306f989483e4b97a8b37dd268de6c8c6f35e75 enabled this
> > behavior for drivers with IEEE80211_HW_PS_NULLFUNC_STACK. We enable this
> > for all drivers supporting dynamic PS.
> >
> > This patch helps improve performance in noisy environments.
>
> FWIW, I don't really consider myself maintaining the PS
> implementation ;-) I don't understand it and think the code is way too
> complex.
Perhaps Kalle can comment? Or...?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-06-20 13:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-18 19:32 [RFC] mac80211: dynamic PS - don't enter PS when TX frames are pending Arik Nemtsov
2011-06-19 8:11 ` Johannes Berg
2011-06-20 13:35 ` John W. Linville [this message]
2011-06-20 13:59 ` Johannes Berg
2011-06-20 14:42 ` Kalle Valo
2011-06-20 17:28 ` Sam Leffler
2011-06-21 4:55 ` Vivek Natarajan
2011-06-21 5:43 ` Arik Nemtsov
2011-06-21 6:33 ` Vivek Natarajan
2011-06-22 8:58 ` Arik Nemtsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620133535.GA2251@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=arik@wizery.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.