From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYhP2-0006fC-Be for qemu-devel@nongnu.org; Mon, 20 Jun 2011 12:32:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QYhP0-00031M-J9 for qemu-devel@nongnu.org; Mon, 20 Jun 2011 12:32:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QYhP0-00030u-9A for qemu-devel@nongnu.org; Mon, 20 Jun 2011 12:32:42 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5KGWeg3006035 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Jun 2011 12:32:40 -0400 Date: Mon, 20 Jun 2011 18:32:30 +0200 From: Alon Levy Message-ID: <20110620163230.GG28412@bow.redhat.com> References: <1308568312-5463-1-git-send-email-alevy@redhat.com> <1308568312-5463-3-git-send-email-alevy@redhat.com> <4DFF3970.8000804@redhat.com> <20110620125821.GB28412@bow.redhat.com> <4DFF543F.9070205@redhat.com> <20110620151107.GE28412@bow.redhat.com> <4DFF6C48.2020401@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DFF6C48.2020401@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: yhalperi@redhat.com, qemu-devel@nongnu.org On Mon, Jun 20, 2011 at 05:50:32PM +0200, Gerd Hoffmann wrote: > On 06/20/11 17:11, Alon Levy wrote: > >On Mon, Jun 20, 2011 at 04:07:59PM +0200, Gerd Hoffmann wrote: > >>>>What is the difference to one worker->stop() + worker->start() cycle? > >>>> > >>> > >>>ok, stop+start won't disconnect any clients either. But does stop render all waiting commands? > >>>I'll have to look, I don't know if it does. > >> > >>It does. This is what qemu uses to flush all spice server state to > >>device memory on migration. > >> > >>What is the reason for deleting all surfaces? > > > >Making sure all references are dropped to pci memory in devram. > > Ah, because the spice server keeps a reference to the create command > until the surface is destroyed, right? Actually right, so my correction stands corrected. > > There is is QXL_IO_DESTROY_ALL_SURFACES + worker->destroy_surfaces() ... > Regarding QXL_IO_DESTROY_ALL_SURFACES, it destroys the primary surface too, which is a little special, that's another difference - update_mem destroys everything except the primary. I know I tried to destroy the primary but it didn't work right, don't recall why right now, so I guess I'll have to retry. > The QXL_IO_UPDATE_MEM command does too much special stuff IMHO. > I also think we don't need to extend the libspice-server API. > > We can add a I/O command which renders everything to device memory > via stop+start. We can zap all surfaces with the existing command + Yes, start+stop work nicely, didn't realize (saw it before, assumed it wouldn't be good enough), just need to destroy the surfaces too. > worker call. We can add a I/O command to ask qxl to push the > release queue head to the release ring. So you suggest to replace QXL_IO_UPDATE_MEM with what, two io commands instead of using the val parameter? QXL_IO_UPDATE_MEM QXL_IO_FLUSH_RELEASE ? > > Comments? > > cheers, > Gerd >