From: Andrew Morton <akpm@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, linux-am33-list@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] linux/uaccess.h needs to #include linux/kernel.h for might_sleep()
Date: Mon, 20 Jun 2011 16:42:41 -0700 [thread overview]
Message-ID: <20110620164241.ac6b5d2a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110615002210.1392.64165.stgit@warthog.procyon.org.uk>
On Wed, 15 Jun 2011 01:22:10 +0100
David Howells <dhowells@redhat.com> wrote:
> linux/uaccess.h needs to #include linux/kernel.h to get might_sleep() otherwise
> it fails to build on MN10300 allyesconfig. This fails in a few places with
> messages like the following:
uaccess.h doesn't textually refer to might_sleep().
> In file included from security/keys/trusted.c:14:
> include/linux/uaccess.h: In function '__copy_from_user_nocache':
> include/linux/uaccess.h:52: error: implicit declaration of function 'might_sleep'
This happened because of arch/mn10300/include/asm/uaccess.h's
#define __copy_from_user(to, from, n) \
({ \
might_sleep(); \
__copy_from_user_inatomic((to), (from), (n)); \
})
> include/linux/uaccess.h | 1 +
So I'd suggest that patching the arch header file is the appropriate fix.
next prev parent reply other threads:[~2011-06-20 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 0:22 [PATCH] linux/uaccess.h needs to #include linux/kernel.h for might_sleep() David Howells
2011-06-20 23:42 ` Andrew Morton [this message]
2011-06-21 9:27 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620164241.ac6b5d2a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.