All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Nicolas Kalkhof <nkalkhof@web.de>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: gen6 (SNB) GPU still stalling besides latest patches
Date: Tue, 21 Jun 2011 09:55:27 -0700	[thread overview]
Message-ID: <20110621095527.2ea996ee@jbarnes-desktop> (raw)
In-Reply-To: <454869881.2698882.1308672776546.JavaMail.fmail@mwmweb017>

On Tue, 21 Jun 2011 18:12:56 +0200 (CEST)
"Nicolas Kalkhof" <nkalkhof@web.de> wrote:

> Hi Jesse,
> 
> thanks for the infiormation. I've switched rc6 off by
> echo 0 > /sys/module/i915/parameters/i915_enable_rc6
> this should do it, right?
> cat /sys/module/i915/parameters/i915_enable_rc6 yields "0"
> 
> Are you referring to this patch? https://lkml.org/lkml/2011/6/17/371
> It should be included in kernel 3.0-rc4 and didn't help here :(

So there are actually a few things that could go wrong in this area.
The problem may be RC6 related, but it could also be turbo related (our
GPU frequency adjustment code).  Can you boot without the module
parameter and try this patch and see what happens (after a cold boot)?

Thanks,
Jesse

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_d
index 81a9059..3c589cb 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7788,9 +7788,6 @@ void intel_modeset_init(struct drm_device *dev)
                intel_init_emon(dev);
        }
 
-       if (IS_GEN6(dev))
-               gen6_enable_rps(dev_priv);
-
        INIT_WORK(&dev_priv->idle_work, intel_idle_update);
        setup_timer(&dev_priv->idle_timer, intel_gpu_idle_timer,
                    (unsigned long)dev);

  reply	other threads:[~2011-06-21 16:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21 16:12 gen6 (SNB) GPU still stalling besides latest patches Nicolas Kalkhof
2011-06-21 16:55 ` Jesse Barnes [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-06-21 18:38 Nicolas Kalkhof
2011-06-21 19:11 ` Chris Wilson
2011-06-21 19:16   ` Andrew Lutomirski
2011-06-21 19:33     ` Chris Wilson
2011-06-21 17:41 Nicolas Kalkhof
2011-06-21 18:18 ` Chris Wilson
2011-06-21 18:24   ` Andrew Lutomirski
     [not found] <935206610.2954520.1308635833489.JavaMail.fmail@mwmweb001>
2011-06-21 16:06 ` Jesse Barnes
2011-06-21 16:01 Nicolas Kalkhof
2011-06-21  5:59 Nicolas Kalkhof
2011-06-20 18:52 Nicolas Kalkhof
2011-06-21  0:01 ` Ted Phelps
2011-06-21  0:19   ` Jesse Barnes
2011-06-22 12:46     ` Ted Phelps

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110621095527.2ea996ee@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=nkalkhof@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.