From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [stable] [PATCH v2] msm: timer: compensate for timer shift in msm_read_timer_count Date: Tue, 21 Jun 2011 09:24:27 -0700 Message-ID: <20110621162427.GA28836@kroah.com> References: <1308344138-2862-1-git-send-email-johlstei@codeaurora.org> <20110620215922.GA21909@kroah.com> <8ya7h8gozhn.fsf@huya.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out2.smtp.messagingengine.com ([66.111.4.26]:46997 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753018Ab1FUQ0G (ORCPT ); Tue, 21 Jun 2011 12:26:06 -0400 Content-Disposition: inline In-Reply-To: <8ya7h8gozhn.fsf@huya.qualcomm.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: David Brown Cc: Russell King , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan Huntsman , Jeff Ohlstein , Daniel Walker , stable@kernel.org, linux-arm-kernel@lists.infradead.org On Mon, Jun 20, 2011 at 04:27:16PM -0700, David Brown wrote: > On Mon, Jun 20 2011, Greg KH wrote: > > > On Fri, Jun 17, 2011 at 01:55:38PM -0700, Jeff Ohlstein wrote: > >> Some msm targets have timers whose lower bits are unreliable. So, we > >> present our timers as lower frequency than they actually are, and ignore > >> the bottom 5 bits on such targets. This compensation was erroneously > >> removed from the msm_read_timer_count function, so restore it. > >> > >> This was broken by 94790ec25 "msm: timer: SMP timer support for msm". > >> > >> Signed-off-by: Jeff Ohlstein > >> --- > >> arch/arm/mach-msm/timer.c | 6 +++++- > >> 1 files changed, 5 insertions(+), 1 deletions(-) > >> > > > > > > > > This is not the correct way to submit patches for inclusion in the > > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > > for how to do this properly. > > > > > > I don't think this patch was intended for stable in the first place. > Jeff, this is a fix for 3.0-rcx, right? Then why was it sent to stable@kernel.org? confused, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: greg@kroah.com (Greg KH) Date: Tue, 21 Jun 2011 09:24:27 -0700 Subject: [stable] [PATCH v2] msm: timer: compensate for timer shift in msm_read_timer_count In-Reply-To: <8ya7h8gozhn.fsf@huya.qualcomm.com> References: <1308344138-2862-1-git-send-email-johlstei@codeaurora.org> <20110620215922.GA21909@kroah.com> <8ya7h8gozhn.fsf@huya.qualcomm.com> Message-ID: <20110621162427.GA28836@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jun 20, 2011 at 04:27:16PM -0700, David Brown wrote: > On Mon, Jun 20 2011, Greg KH wrote: > > > On Fri, Jun 17, 2011 at 01:55:38PM -0700, Jeff Ohlstein wrote: > >> Some msm targets have timers whose lower bits are unreliable. So, we > >> present our timers as lower frequency than they actually are, and ignore > >> the bottom 5 bits on such targets. This compensation was erroneously > >> removed from the msm_read_timer_count function, so restore it. > >> > >> This was broken by 94790ec25 "msm: timer: SMP timer support for msm". > >> > >> Signed-off-by: Jeff Ohlstein > >> --- > >> arch/arm/mach-msm/timer.c | 6 +++++- > >> 1 files changed, 5 insertions(+), 1 deletions(-) > >> > > > > > > > > This is not the correct way to submit patches for inclusion in the > > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > > for how to do this properly. > > > > > > I don't think this patch was intended for stable in the first place. > Jeff, this is a fix for 3.0-rcx, right? Then why was it sent to stable at kernel.org? confused, greg k-h