All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: <linux-kernel@vger.kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Subject: 3.0-rc3: new sparse noise on module_param_named: "error: Syntax error in unary expression"
Date: Tue, 21 Jun 2011 16:30:40 +0200	[thread overview]
Message-ID: <20110621163040.717fd5ed@stein> (raw)

Hi,

make C=1 in 3.0-rc3 but not in 2.6.39 complains:

  CHECK   drivers/firewire/ohci.c
drivers/firewire/ohci.c:308:1: error: Syntax error in unary expression
drivers/firewire/ohci.c:325:1: error: Syntax error in unary expression
  CC [M]  drivers/firewire/ohci.o
  CHECK   drivers/firewire/sbp2.c
drivers/firewire/sbp2.c:70:1: error: Syntax error in unary expression
drivers/firewire/sbp2.c:116:1: error: Syntax error in unary expression
  CC [M]  drivers/firewire/sbp2.o

These lines are the module_param_named lines of:

static int param_quirks;
module_param_named(quirks, param_quirks, int, 0644);
MODULE_PARM_DESC(quirks, "Chip quirks (default = 0"
[...]
static int param_debug;
module_param_named(debug, param_debug, int, 0644);
MODULE_PARM_DESC(debug, "Verbose logging (default = 0"
[...]

and

static int sbp2_param_exclusive_login = 1;
module_param_named(exclusive_login, sbp2_param_exclusive_login, bool, 0644);
MODULE_PARM_DESC(exclusive_login, "Exclusive login to sbp2 device "
[...]
static int sbp2_param_workarounds;
module_param_named(workarounds, sbp2_param_workarounds, int, 0644);
MODULE_PARM_DESC(workarounds, "Work around device bugs (default = 0"
[...]

Seen with an older version of sparse (perhaps 0.4.2) and the current from
sparse.git (0.4.3 plus 13 commmits).

There is only a single change to the kernel's include/linux/moduleparam.h
after v2.6.39, "module: reorder kparam_array to remove alignment padding
on 64 bit builds", and that one is apparently not the cause of the noise.

Puzzled,
-- 
Stefan Richter
-=====-==-== -==- =-=-=
http://arcgraph.de/sr/

             reply	other threads:[~2011-06-21 14:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21 14:30 Stefan Richter [this message]
     [not found] ` <20110622210504.0ceb268d.rdunlap@xenotime.net>
2011-06-23 12:56   ` 3.0-rc3: new sparse noise on module_param_named: "error: Syntax error in unary expression" Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110621163040.717fd5ed@stein \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.