From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 02 of 22] tools: merge several bitop functions into xc_bitops.h Date: Tue, 21 Jun 2011 19:17:46 +0200 Message-ID: <20110621171745.GA24478@aepfle.de> References: <9476d85932e5eb8f1e7c.1307697171@probook.site> <19968.50159.462491.332465@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <19968.50159.462491.332465@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, Jun 21, Ian Jackson wrote: > Olaf Hering writes ("[Xen-devel] [PATCH 02 of 22] tools: merge several bitop functions into xc_bitops.h"): > > tools: merge several bitop functions into xc_bitops.h > > This seems to break the stubdom build, I'm afraid. > xc_domain_save.c:30:23: error: xc_bitops.h: No such file or directory (I just ran 'make tools' to verify my changes, not make or 'make stubdom') Why are the symlinks not updated? I can not reproduce the failure in a fresh build. xc_domain_save.c references other files like xc_private.h in the same directory. So I think the bug is not strictly in my change, but may point to some other bug. Maybe its related to the issue I ran often while working on this series: Repeated hg qpush/qpop with a patch that adds a new header or removes an existing one, does not update the .*.d file. As a result, make fails because there is 'no rule to make target foo.h'. The only way is to do a make clean in these directories to remove the .*.d files. ... time passes. ... I can reproduce it now with a fresh build without patches, then apply just this patch and run make again. First tools/xenpaging/ fails because there is now 'no rule to make target bitops.h'. A 'rm tools/xenpaging/.*.d ; make' fixes it. Now it fails as you describe. Olaf