From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: Re: Konrad devel/next-3.0, pci-passthrough not working: Error: pci: PCI Backend and pci-stub don't own device Date: Wed, 22 Jun 2011 10:28:13 -0400 Message-ID: <20110622142813.GA6285@dumpdata.com> References: <437780710.20110621154126@eikelenboom.it> <20110621141355.GA15205@dumpdata.com> <1918309554.20110621171142@eikelenboom.it> <20110621170525.GA10328@dumpdata.com> <1284512453.20110621210229@eikelenboom.it> <20110622140022.GB5574@dumpdata.com> <717240289.20110622161313@eikelenboom.it> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="ZPt4rx8FFjLCG7dd" Return-path: Content-Disposition: inline In-Reply-To: <717240289.20110622161313@eikelenboom.it> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Sander Eikelenboom Cc: "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > >> >> module name: xen_pciback > >> >> driver: pciback > >> >> > >> >> Quite a mix of names, and different use of minus and underscore. > >> > >> > Hmm, you are a right. I somehow I thought I backed up the patch that > >> > used the wrong name (well, not wrong but just incorrect). > >> > >> So if I understand you correct you will revert the driver name from xen-pciback to pciback, so no xen change is needed ? > > > So this patch: > > f3fc28d52f42220bcce8c2fed12aef2a88c9fadc > > > xen/pciback: revert the name of the PCI driver to 'pciback'. > > > should have done the trick but I am not seeing it in the > > devel/xen-pciback-0.6.. Aha! I forgot to push the branch up to git.kernel.org. > > > Before I do that, can you cherry-pick that one please and tell > > me if it works? If it does I will stick 'Reported-by' and 'Tested-by' > > on the patch if you are OK with that. > > And were exactly do i cherry pick that from ? :-) since you say you haven't pushed it :p > If you can attach the patch i will test it right away, sticking the reported and tested-by is fine ! See attached or inline: commit f3fc28d52f42220bcce8c2fed12aef2a88c9fadc Author: Konrad Rzeszutek Wilk Date: Wed Apr 20 16:06:47 2011 -0400 xen/pciback: revert the name of the PCI driver to 'pciback'. At least until the toolstack catches up and it will be able to handle 'xen_pciback'. This means we have these directories in sysfs: ./bus/pci/drivers/pciback ./bus/xen-backend/drivers/xen-pciback ./module/xen_pciback Signed-off-by: Konrad Rzeszutek Wilk diff --git a/drivers/pci/xen-pciback/pci_stub.c b/drivers/pci/xen-pciback/pci_stub.c index d802261..aec214a 100644 --- a/drivers/pci/xen-pciback/pci_stub.c +++ b/drivers/pci/xen-pciback/pci_stub.c @@ -848,7 +848,9 @@ static struct pci_error_handlers xen_pcibk_error_handler = { */ static struct pci_driver xen_pcibk_pci_driver = { - .name = DRV_NAME, + /* The name should be xen_pciback, but until the tools are updated + * we will keep it as pciback. */ + .name = "pciback", .id_table = pcistub_ids, .probe = pcistub_probe, .remove = pcistub_remove, --ZPt4rx8FFjLCG7dd Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="pciback.patch" commit f3fc28d52f42220bcce8c2fed12aef2a88c9fadc Author: Konrad Rzeszutek Wilk Date: Wed Apr 20 16:06:47 2011 -0400 xen/pciback: revert the name of the PCI driver to 'pciback'. At least until the toolstack catches up and it will be able to handle 'xen_pciback'. This means we have these directories in sysfs: ./bus/pci/drivers/pciback ./bus/xen-backend/drivers/xen-pciback ./module/xen_pciback Signed-off-by: Konrad Rzeszutek Wilk diff --git a/drivers/pci/xen-pciback/pci_stub.c b/drivers/pci/xen-pciback/pci_stub.c index d802261..aec214a 100644 --- a/drivers/pci/xen-pciback/pci_stub.c +++ b/drivers/pci/xen-pciback/pci_stub.c @@ -848,7 +848,9 @@ static struct pci_error_handlers xen_pcibk_error_handler = { */ static struct pci_driver xen_pcibk_pci_driver = { - .name = DRV_NAME, + /* The name should be xen_pciback, but until the tools are updated + * we will keep it as pciback. */ + .name = "pciback", .id_table = pcistub_ids, .probe = pcistub_probe, .remove = pcistub_remove, --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --ZPt4rx8FFjLCG7dd--