Re: [PATCH 1/2] drm/i915: more forcewake lock error info

[Ben Widawsky <ben@bwidawsk.net>]

On Wed, Jun 22, 2011 at 06:15:40PM +0100, Chris Wilson wrote:
> On Wed, 22 Jun 2011 10:07:50 -0700, Ben Widawsky <bwidawsk@gmail.com> wrote:
> > On Wed, Jun 22, 2011 at 10:00 AM, Chris Wilson <chris@chris-wilson.co.uk>wrote:
> > 
> > > On Wed, 22 Jun 2011 09:55:00 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> > > > Get some more useful info for debugging backtraces on forcewake
> > > > problems. Appropriate debug flags will be required for the drm module.
> > >
> > > Wouldn't it be neater to pass the reg down to
> > > gen6_gt_force_wake_get() so that we only have a single debug message and
> > > not an additional one for every inlined read/write?
> > > -Chris
> > >
> > 
> > Urg... having some trouble with my email right now, so you have to deal with
> > my gmail/webmail...
> > 
> > 1. Yes, but I was lazy.
> > 2. People call force_wake_get() without actually specifying a register, so I
> > didn't want to enforce people entering bogus info on those calls.
> 
> We could always go for the traditional file:line automagic macros...
> But we already have that from the stacktrace if people are good enough to
> provide symbols.

Yeah, I figured this would be easiest as it somewhat removes variance
between commits, I can just search for the unprotected register access
on the branch du jour (especially with you guys refactoring the code all
time time...  JBARNES).

I'm fine if the consensus is to throw this one out. Seemed helpful at
the time, so I thought I'd post it.

> -Chris

Ben