From: Al Viro <viro@ZenIV.linux.org.uk>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [nfs, rpc] crap with refcounting and rmmod races
Date: Wed, 22 Jun 2011 23:58:15 +0100 [thread overview]
Message-ID: <20110622225815.GG11521@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1308782934.25875.22.camel@lade.trondhjem.org>
On Wed, Jun 22, 2011 at 06:48:54PM -0400, Trond Myklebust wrote:
> It is fairly trivial to define a 'struct nfs_path' that takes a
> reference to the dentry and a reference to the super block if you'd
> prefer that we get rid of the 'struct path' in nfs_open_context.
Er... as opposed to struct dentry *dentry and its ->d_sb? ;-)
See the last few patches in #untested (vfs-2.6.git) doing more
or less that (and nfs4_closedata is just fine with data->inode->i_sb -
it doesn't need to pin any dentries at all; nfs4_opendata and
nfs_open_context need dentry, of course).
next prev parent reply other threads:[~2011-06-22 22:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 19:12 [nfs, rpc] crap with refcounting and rmmod races Al Viro
2011-06-22 19:12 ` Al Viro
2011-06-22 19:31 ` Al Viro
2011-06-22 19:31 ` Al Viro
2011-06-22 21:51 ` Al Viro
2011-06-22 21:51 ` Al Viro
2011-06-22 22:48 ` Trond Myklebust
2011-06-22 22:58 ` Al Viro [this message]
2011-06-22 23:05 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110622225815.GG11521@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.