From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Stephane Eranian <eranian@google.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Don Zickus <dzickus@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Lin Ming <ming.m.lin@intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Vince Weaver <vweaver1@eecs.utk.edu>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] perf, x86: Add PERF_COUNT_HW_NMI_WATCHDOG event v2
Date: Thu, 23 Jun 2011 13:54:40 +0400 [thread overview]
Message-ID: <20110623095439.GC10238@sun> (raw)
In-Reply-To: <BANLkTikVaOz5DYjKSU-jxVBw_Lw9ihV7BQ@mail.gmail.com>
On Thu, Jun 23, 2011 at 11:40:39AM +0200, Stephane Eranian wrote:
> On Thu, Jun 23, 2011 at 8:48 AM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> > On Wed, Jun 22, 2011 at 01:21:34PM +0400, Cyrill Gorcunov wrote:
> > ...
> >> Note that I've not tested it but rather need approval/rejecting
> >> on idea in general.
> >
> > The final version is below. Stephane, note that it's almost the
> > same idea as you proposed except it uses explicit namings to
> > mark out that watchdog cycles are special.
> >
> This looks okay.
>
> The only alternative I see (This is wha I had in mind at the
> beginning) that would
> not require this new hidden generic event would be to have watchdog.c invoke an
> arch-specific callback to fill out the attr.type, attr->config fields directly:
>
...
>
> No new hidden event, just a x86_pmu + a per-arch callbacks.
Looks quite good for me, Don? (i'll cook some draft patch for review meanwhile).
Cyrill
next prev parent reply other threads:[~2011-06-23 9:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 15:37 [RFC -tip] perf, x86: Add PERF_COUNT_HW_NMI_WATCHDOG event v2 Cyrill Gorcunov
2011-06-21 15:23 ` Don Zickus
2011-06-21 15:40 ` Cyrill Gorcunov
2011-06-21 15:58 ` Peter Zijlstra
2011-06-21 16:13 ` Cyrill Gorcunov
2011-06-21 16:20 ` Stephane Eranian
2011-06-21 16:48 ` Cyrill Gorcunov
2011-06-21 17:02 ` Cyrill Gorcunov
2011-06-21 17:10 ` Stephane Eranian
2011-06-21 17:23 ` Cyrill Gorcunov
2011-06-21 17:26 ` Stephane Eranian
2011-06-21 17:54 ` Cyrill Gorcunov
2011-06-21 18:06 ` Stephane Eranian
2011-06-21 18:32 ` Cyrill Gorcunov
2011-06-22 8:27 ` Cyrill Gorcunov
2011-06-22 9:21 ` Cyrill Gorcunov
2011-06-23 6:48 ` Cyrill Gorcunov
2011-06-23 9:40 ` Stephane Eranian
2011-06-23 9:54 ` Cyrill Gorcunov [this message]
2011-06-23 11:07 ` Cyrill Gorcunov
2011-06-23 11:40 ` Don Zickus
2011-06-23 11:44 ` Stephane Eranian
2011-06-23 11:53 ` Cyrill Gorcunov
2011-06-23 12:03 ` Stephane Eranian
2011-06-23 12:07 ` Cyrill Gorcunov
2011-06-23 12:26 ` Cyrill Gorcunov
2011-06-23 12:31 ` Stephane Eranian
2011-06-23 12:34 ` Cyrill Gorcunov
2011-06-23 11:51 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110623095439.GC10238@sun \
--to=gorcunov@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dzickus@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=vweaver1@eecs.utk.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.