From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: duplicate code in dir2
Date: Thu, 23 Jun 2011 07:03:18 -0400 [thread overview]
Message-ID: <20110623110317.GA21174@infradead.org> (raw)
In-Reply-To: <4E020977.9080000@sandeen.net>
On Wed, Jun 22, 2011 at 10:25:43AM -0500, Eric Sandeen wrote:
> Another interesting chunk elsewhere:
>
> /src/git/linux-2.6/fs/xfs/xfs_da_btree.c(782)
> /src/git/linux-2.6/fs/xfs/xfs_attr_leaf.c(1542)
> *action = 0;
> return(0);
> if (count == 0) {
The da_btree code is a big mess with things duplicated all over.
There's a third copy of this in the dir2 code as well. I have started
consolidating some of this code a while ago in prepation of adding
checksumming to the dir and attr code, but it has bit rotted a bit since
and I've not managed to get back to it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-06-23 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 15:24 duplicate code in dir2 Eric Sandeen
2011-06-22 15:25 ` Eric Sandeen
2011-06-23 11:03 ` Christoph Hellwig [this message]
2011-06-23 10:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110623110317.GA21174@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.