From: Mandeep Singh Baines <msb@google.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: Mandeep Singh Baines <msb@chromium.org>,
David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Joe Perches <joe@perches.com>
Subject: [PATCH v3] crypto: sha1: use SHA1_BLOCK_SIZE
Date: Thu, 23 Jun 2011 12:02:27 -0700 [thread overview]
Message-ID: <20110623190227.GH13916@google.com> (raw)
In-Reply-To: <20110531052245.GA17068@gondor.apana.org.au>
Modify sha1_update to use SHA1_BLOCK_SIZE.
Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
---
crypto/sha1_generic.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/crypto/sha1_generic.c b/crypto/sha1_generic.c
index 0416091..00ae60e 100644
--- a/crypto/sha1_generic.c
+++ b/crypto/sha1_generic.c
@@ -43,25 +43,26 @@ static int sha1_update(struct shash_desc *desc, const u8 *data,
unsigned int partial, done;
const u8 *src;
- partial = sctx->count & 0x3f;
+ partial = sctx->count % SHA1_BLOCK_SIZE;
sctx->count += len;
done = 0;
src = data;
- if ((partial + len) > 63) {
+ if ((partial + len) >= SHA1_BLOCK_SIZE) {
u32 temp[SHA_WORKSPACE_WORDS];
if (partial) {
done = -partial;
- memcpy(sctx->buffer + partial, data, done + 64);
+ memcpy(sctx->buffer + partial, data,
+ done + SHA1_BLOCK_SIZE);
src = sctx->buffer;
}
do {
sha_transform(sctx->state, src, temp);
- done += 64;
+ done += SHA1_BLOCK_SIZE;
src = data + done;
- } while (done + 63 < len);
+ } while (done + SHA1_BLOCK_SIZE <= len);
memset(temp, 0, sizeof(temp));
partial = 0;
--
1.7.3.1
next prev parent reply other threads:[~2011-06-23 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 3:11 [PATCH] crypto: sha1: modify sha1_update to use SHA1_BLOCK_SIZE Mandeep Singh Baines
2011-05-26 3:34 ` David Miller
2011-05-26 3:52 ` Joe Perches
2011-05-26 23:20 ` [PATCH v2] " Mandeep Singh Baines
2011-05-31 5:22 ` Herbert Xu
2011-05-31 5:22 ` Herbert Xu
2011-06-23 19:02 ` Mandeep Singh Baines [this message]
2011-06-27 7:42 ` [PATCH v3] crypto: sha1: " Herbert Xu
2011-06-27 7:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110623190227.GH13916@google.com \
--to=msb@google.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=joe@perches.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.