From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Mike Frysinger <vapier@gentoo.org>, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: Fix Blackfin I2S _pointer() implementation return in bounds values
Date: Thu, 23 Jun 2011 20:21:50 +0100 [thread overview]
Message-ID: <20110623192149.GC24328@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4E038FA7.40509@metafoo.de>
On Thu, Jun 23, 2011 at 09:10:31PM +0200, Lars-Peter Clausen wrote:
> On 06/23/2011 09:02 PM, Mark Brown wrote:
> > [...]
> > + if (diff == snd_pcm_lib_buffer_bytes(substream))
> > + diff = 0;
> > + }
> stray closing bracket
Hrm, so there is. Fixed locally, I guess there's no point in reposting
just for that.
> > + frames = bytes_to_frames(substream->runtime, diff);
> > +
> > return frames;
> Could be 'return bytes_to_frames(substream->runtime, diff);' directly
Does no harm either way, though. I don't always find doing the return
directly quite so parsable, but I think here I wrote it this way because
it makes the diff a bit more obvious.
next prev parent reply other threads:[~2011-06-23 19:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 19:02 [PATCH] ASoC: Fix Blackfin I2S _pointer() implementation return in bounds values Mark Brown
2011-06-23 19:10 ` Lars-Peter Clausen
2011-06-23 19:21 ` Mark Brown [this message]
2011-06-29 15:36 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110623192149.GC24328@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.