diff for duplicates of <20110623231305.GA1312@thinkpad> diff --git a/a/1.txt b/N1/1.txt index e2a8be4..1c124c6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -36,20 +36,20 @@ On Fri, Jun 24, 2011 at 07:06:42AM +0900, Minchan Kim wrote: > > > > Testcase: > > -> > - create a 1GB file called "zero" -> > - run md5sum zero to read all the pages in page cache (this is to -> > simulate the user activity on this file) -> > - run "rsync zero zero_copy" (rsync is patched with [3]) -> > - re-run md5sum zero (user activity on the working set) and measure -> > the time to complete this command +> > - create a 1GB file called "zero" +> > - run md5sum zero to read all the pages in page cache (this is to +> > simulate the user activity on this file) +> > - run "rsync zero zero_copy" (rsync is patched with [3]) +> > - re-run md5sum zero (user activity on the working set) and measure +> > the time to complete this command > > > > The test has been performed using 3.0.0-rc4 vanilla and with this patch > > applied (3.0.0-rc4-fadvise). > > > > Results: -> > avg elapsed time block:block_bio_queue -> > 3.0.0-rc4 4.127s 8,214 -> > 3.0.0-rc4-fadvise 2.146s 0 +> > avg elapsed time block:block_bio_queue +> > 3.0.0-rc4 4.127s 8,214 +> > 3.0.0-rc4-fadvise 2.146s 0 > > > > Great! @@ -64,24 +64,24 @@ On Fri, Jun 24, 2011 at 07:06:42AM +0900, Minchan Kim wrote: > > [3] http://lists.samba.org/archive/rsync/2010-November/025827.html > > > > ChangeLog v1 -> v2: -> > - fix comment in invalidate_mapping_pages() +> > - fix comment in invalidate_mapping_pages() > > > > Acked-by: Rik van Riel <riel@redhat.com> > > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > Signed-off-by: Andrea Righi <andrea@betterlinux.com> > > --- -> > mm/swap.c | 9 +++++---- -> > mm/truncate.c | 10 +++++++--- -> > 2 files changed, 12 insertions(+), 7 deletions(-) +> > mm/swap.c | 9 +++++---- +> > mm/truncate.c | 10 +++++++--- +> > 2 files changed, 12 insertions(+), 7 deletions(-) > > > > diff --git a/mm/swap.c b/mm/swap.c > > index 3a442f1..fc8bb76 100644 > > --- a/mm/swap.c > > +++ b/mm/swap.c > > @@ -411,10 +411,11 @@ void add_page_to_unevictable_list(struct page *page) -> > * -> > * 1. active, mapped page -> none -> > * 2. active, dirty/writeback page -> inactive, head, PG_reclaim +> > * +> > * 1. active, mapped page -> none +> > * 2. active, dirty/writeback page -> inactive, head, PG_reclaim > > - * 3. inactive, mapped page -> none > > - * 4. inactive, dirty/writeback page -> inactive, head, PG_reclaim > > - * 5. inactive, clean -> inactive, tail @@ -106,18 +106,18 @@ Agreed. Oh right. I'd put both on a single line anyway, as you suggested. > -> > * -> > * In 4, why it moves inactive's head, the VM expects the page would -> > * be write it out by flusher threads as this is much more effective +> > * +> > * In 4, why it moves inactive's head, the VM expects the page would +> > * be write it out by flusher threads as this is much more effective > > diff --git a/mm/truncate.c b/mm/truncate.c > > index 3a29a61..a36af48 100644 > > --- a/mm/truncate.c > > +++ b/mm/truncate.c > > @@ -357,11 +357,15 @@ unsigned long invalidate_mapping_pages(struct address_space *mapping, -> > if (lock_failed) -> > continue; +> > if (lock_failed) +> > continue; > > -> > - ret = invalidate_inode_page(page); +> > - ret = invalidate_inode_page(page); > > I would like to add comment. > "Invalidation of active page is rather aggressive as we can't make @@ -129,10 +129,10 @@ Oh right. I'd put both on a single line anyway, as you suggested. OK. > -> > + if (PageActive(page)) -> > + ret = 0; -> > + else -> > + ret = invalidate_inode_page(page); +> > + if (PageActive(page)) +> > + ret = 0; +> > + else +> > + ret = invalidate_inode_page(page); > > > You have to change description of invalidate_mapping_pages. @@ -144,16 +144,16 @@ OK. Correct. > -> > unlock_page(page); -> > /* -> > - * Invalidation is a hint that the page is no longer -> > - * of interest and try to speed up its reclaim. -> > + * Invalidation of an inactive page is a hint that the -> > + * page is no longer of interest and try to speed up -> > + * its reclaim. -> > */ -> > if (!ret) -> > deactivate_page(page); +> > unlock_page(page); +> > /* +> > - * Invalidation is a hint that the page is no longer +> > - * of interest and try to speed up its reclaim. +> > + * Invalidation of an inactive page is a hint that the +> > + * page is no longer of interest and try to speed up +> > + * its reclaim. +> > */ +> > if (!ret) +> > deactivate_page(page); > > -- > > 1.7.4.1 > > @@ -172,3 +172,10 @@ Thanks for the review. I'll add all your comments and post a new version. -Andrea + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index bfbcbf3..5db5cd7 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -57,20 +57,20 @@ "> >\n" "> > Testcase:\n" "> >\n" - "> > \302\240- create a 1GB file called \"zero\"\n" - "> > \302\240- run md5sum zero to read all the pages in page cache (this is to\n" - "> > \302\240 \302\240simulate the user activity on this file)\n" - "> > \302\240- run \"rsync zero zero_copy\" (rsync is patched with [3])\n" - "> > \302\240- re-run md5sum zero (user activity on the working set) and measure\n" - "> > \302\240 \302\240the time to complete this command\n" + "> > - create a 1GB file called \"zero\"\n" + "> > - run md5sum zero to read all the pages in page cache (this is to\n" + "> > simulate the user activity on this file)\n" + "> > - run \"rsync zero zero_copy\" (rsync is patched with [3])\n" + "> > - re-run md5sum zero (user activity on the working set) and measure\n" + "> > the time to complete this command\n" "> >\n" "> > The test has been performed using 3.0.0-rc4 vanilla and with this patch\n" "> > applied (3.0.0-rc4-fadvise).\n" "> >\n" "> > Results:\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240avg elapsed time \302\240 \302\240 \302\240block:block_bio_queue\n" - "> > \302\2403.0.0-rc4 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\2404.127s \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\2408,214\n" - "> > \302\2403.0.0-rc4-fadvise \302\240 \302\240 \302\240 \302\240 \302\2402.146s \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\2400\n" + "> > avg elapsed time block:block_bio_queue\n" + "> > 3.0.0-rc4 4.127s 8,214\n" + "> > 3.0.0-rc4-fadvise 2.146s 0\n" "> >\n" "> \n" "> Great!\n" @@ -85,24 +85,24 @@ "> > [3] http://lists.samba.org/archive/rsync/2010-November/025827.html\n" "> >\n" "> > ChangeLog v1 -> v2:\n" - "> > \302\240- fix comment in invalidate_mapping_pages()\n" + "> > - fix comment in invalidate_mapping_pages()\n" "> >\n" "> > Acked-by: Rik van Riel <riel@redhat.com>\n" "> > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>\n" "> > Signed-off-by: Andrea Righi <andrea@betterlinux.com>\n" "> > ---\n" - "> > \302\240mm/swap.c \302\240 \302\240 | \302\240 \302\2409 +++++----\n" - "> > \302\240mm/truncate.c | \302\240 10 +++++++---\n" - "> > \302\2402 files changed, 12 insertions(+), 7 deletions(-)\n" + "> > mm/swap.c | 9 +++++----\n" + "> > mm/truncate.c | 10 +++++++---\n" + "> > 2 files changed, 12 insertions(+), 7 deletions(-)\n" "> >\n" "> > diff --git a/mm/swap.c b/mm/swap.c\n" "> > index 3a442f1..fc8bb76 100644\n" "> > --- a/mm/swap.c\n" "> > +++ b/mm/swap.c\n" "> > @@ -411,10 +411,11 @@ void add_page_to_unevictable_list(struct page *page)\n" - "> > \302\240*\n" - "> > \302\240* 1. active, mapped page -> none\n" - "> > \302\240* 2. active, dirty/writeback page -> inactive, head, PG_reclaim\n" + "> > *\n" + "> > * 1. active, mapped page -> none\n" + "> > * 2. active, dirty/writeback page -> inactive, head, PG_reclaim\n" "> > - * 3. inactive, mapped page -> none\n" "> > - * 4. inactive, dirty/writeback page -> inactive, head, PG_reclaim\n" "> > - * 5. inactive, clean -> inactive, tail\n" @@ -127,18 +127,18 @@ "Oh right. I'd put both on a single line anyway, as you suggested.\n" "\n" "> \n" - "> > \302\240*\n" - "> > \302\240* In 4, why it moves inactive's head, the VM expects the page would\n" - "> > \302\240* be write it out by flusher threads as this is much more effective\n" + "> > *\n" + "> > * In 4, why it moves inactive's head, the VM expects the page would\n" + "> > * be write it out by flusher threads as this is much more effective\n" "> > diff --git a/mm/truncate.c b/mm/truncate.c\n" "> > index 3a29a61..a36af48 100644\n" "> > --- a/mm/truncate.c\n" "> > +++ b/mm/truncate.c\n" "> > @@ -357,11 +357,15 @@ unsigned long invalidate_mapping_pages(struct address_space *mapping,\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240if (lock_failed)\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240continue;\n" + "> > if (lock_failed)\n" + "> > continue;\n" "> >\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 ret = invalidate_inode_page(page);\n" + "> > - ret = invalidate_inode_page(page);\n" "> \n" "> I would like to add comment.\n" "> \"Invalidation of active page is rather aggressive as we can't make\n" @@ -150,10 +150,10 @@ "OK.\n" "\n" "> \n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 if (PageActive(page))\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 ret = 0;\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 else\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 ret = invalidate_inode_page(page);\n" + "> > + if (PageActive(page))\n" + "> > + ret = 0;\n" + "> > + else\n" + "> > + ret = invalidate_inode_page(page);\n" "> \n" "> \n" "> You have to change description of invalidate_mapping_pages.\n" @@ -165,16 +165,16 @@ "Correct.\n" "\n" "> \n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240unlock_page(page);\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240/*\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* Invalidation is a hint that the page is no longer\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* of interest and try to speed up its reclaim.\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* Invalidation of an inactive page is a hint that the\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* page is no longer of interest and try to speed up\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240* its reclaim.\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 */\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240if (!ret)\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240deactivate_page(page);\n" + "> > unlock_page(page);\n" + "> > /*\n" + "> > - * Invalidation is a hint that the page is no longer\n" + "> > - * of interest and try to speed up its reclaim.\n" + "> > + * Invalidation of an inactive page is a hint that the\n" + "> > + * page is no longer of interest and try to speed up\n" + "> > + * its reclaim.\n" + "> > */\n" + "> > if (!ret)\n" + "> > deactivate_page(page);\n" "> > --\n" "> > 1.7.4.1\n" "> >\n" @@ -192,6 +192,13 @@ "\n" "I'll add all your comments and post a new version.\n" "\n" - -Andrea + "-Andrea\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -433cf63afd7f8dd7f020f37518e3c597cdcf312324314ff2537e1b73a961821f +9406bc6e314f91dda388e97b581c9618ce5874fc380a52209dd7203ffe373f74
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.