From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] usb: renesas_usbhs: use dma handler
Date: Fri, 24 Jun 2011 07:11:25 +0000 [thread overview]
Message-ID: <20110624071125.GB26504@linux-sh.org> (raw)
In-Reply-To: <w3psjr3yauo.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Jun 21, 2011 at 07:34:17PM +0900, Kuninori Morimoto wrote:
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > > drivers/usb/renesas_usbhs/mod_gadget.c | 4 ++--
> > > 1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > Does this have any dependencies? What about platforms that don't support
> > dmaengine?
>
> renesas_usbhs driver will use PIO mode if platforms doesn't have/support
> dmaengine
>
> more explain or rename needed ?
>
No, that's fine. It wasn't immediately obvious that the PIO fallback and
overriding of the handler was being done in the DMA routines. Looks good
to me, I'll let Greg pick it up for usb-next.
prev parent reply other threads:[~2011-06-24 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 6:09 [PATCH] usb: renesas_usbhs: use dma handler Kuninori Morimoto
2011-06-21 8:37 ` Paul Mundt
2011-06-21 10:34 ` Kuninori Morimoto
2011-06-24 7:11 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110624071125.GB26504@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.