From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Subject: Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure Date: Fri, 24 Jun 2011 13:09:06 +0100 Message-ID: <20110624120906.GB6327@linux-mips.org> References: <20110623144750.GA10180@linux-mips.org> <20110624111608.GA6327@linux-mips.org> <4E04767A.5020201@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from duck.linux-mips.net (h5.dl5rb.org.uk [81.2.74.5]) by alsa0.perex.cz (Postfix) with ESMTP id 996F824489 for ; Fri, 24 Jun 2011 14:09:09 +0200 (CEST) Content-Disposition: inline In-Reply-To: <4E04767A.5020201@infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mauro Carvalho Chehab Cc: linux-mips@linux-mips.org, alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Fri, Jun 24, 2011 at 08:35:22AM -0300, Mauro Carvalho Chehab wrote: > Em 24-06-2011 08:16, Ralf Baechle escreveu: > > tristate "miroSOUND PCM20 radio" > > depends on ISA && VIDEO_V4L2 && SND > > select SND_ISA > > select SND_MIRO > > > > So SND_ISA gets forced on even though the dependency on ISA_DMA_API is not > > fulfilled. That's solved by adding the dependency on ISA_DMA_API to > > RADIO_MIROPCM20. > > Another option would be to convert the two above selects into depends on. Depends has the disadvantage that users may have to enable unobvious options first before they are offered the one they are looking for and that's what a "depends SND_ISA" would cause in this case. Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 24 Jun 2011 14:09:21 +0200 (CEST) Received: from h5.dl5rb.org.uk ([81.2.74.5]:55840 "EHLO duck.linux-mips.net" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S1491832Ab1FXMJQ (ORCPT ); Fri, 24 Jun 2011 14:09:16 +0200 Received: from duck.linux-mips.net (duck.linux-mips.net [127.0.0.1]) by duck.linux-mips.net (8.14.4/8.14.3) with ESMTP id p5OC97u2024300; Fri, 24 Jun 2011 13:09:07 +0100 Received: (from ralf@localhost) by duck.linux-mips.net (8.14.4/8.14.4/Submit) id p5OC96Fu024297; Fri, 24 Jun 2011 13:09:06 +0100 Date: Fri, 24 Jun 2011 13:09:06 +0100 From: Ralf Baechle To: Mauro Carvalho Chehab Cc: Takashi Iwai , Jaroslav Kysela , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-mips@linux-mips.org Subject: Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure Message-ID: <20110624120906.GB6327@linux-mips.org> References: <20110623144750.GA10180@linux-mips.org> <20110624111608.GA6327@linux-mips.org> <4E04767A.5020201@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E04767A.5020201@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-archive-position: 30506 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk X-list: linux-mips Return-Path: X-Keywords: X-UID: 20269 On Fri, Jun 24, 2011 at 08:35:22AM -0300, Mauro Carvalho Chehab wrote: > Em 24-06-2011 08:16, Ralf Baechle escreveu: > > tristate "miroSOUND PCM20 radio" > > depends on ISA && VIDEO_V4L2 && SND > > select SND_ISA > > select SND_MIRO > > > > So SND_ISA gets forced on even though the dependency on ISA_DMA_API is not > > fulfilled. That's solved by adding the dependency on ISA_DMA_API to > > RADIO_MIROPCM20. > > Another option would be to convert the two above selects into depends on. Depends has the disadvantage that users may have to enable unobvious options first before they are offered the one they are looking for and that's what a "depends SND_ISA" would cause in this case. Ralf