From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] tools: fix build after recent xenpaging
	changes
Date: Fri, 24 Jun 2011 15:57:08 +0200
Message-ID: <20110624135708.GA28839@aepfle.de>
References: <20110624121613.GA17634@whitby.uk.xensource.com>
	<1308918826.32717.85.camel@zakaz.uk.xensource.com>
	<20110624133201.GB27793@aepfle.de>
	<1308923299.32717.109.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <1308923299.32717.109.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Tim Deegan <Tim.Deegan@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Jun 24, Ian Campbell wrote:

> In fact since the page-in thread is doing relatively expensive work I'd
> expect that the trigger loop would get to run several iterations for
> each time the page-in loop ran..

That did not happen for me, I will think about it.

> > If the caller of page_in_trigger will find the gfn is still in paging
> > state, it will just try again.
> 
> I don't see where it would go back and try page 1 again if it gets
> missed (as in the above example)

The break exits the for() loop, not the while(1). In the next iteration
page 1 may still be in paging->bitmap and tried again.

Olaf