From: Olaf Hering <olaf@aepfle.de>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Tim Deegan <Tim.Deegan@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] tools: fix build after recent xenpaging changes
Date: Fri, 24 Jun 2011 16:35:12 +0200 [thread overview]
Message-ID: <20110624143511.GA30080@aepfle.de> (raw)
In-Reply-To: <1308925806.32717.119.camel@zakaz.uk.xensource.com>
On Fri, Jun 24, Ian Campbell wrote:
> > The break exits the for() loop, not the while(1). In the next iteration
> > page 1 may still be in paging->bitmap and tried again.
>
> I'd missed the interrupted -> 1 in the while loop. I presume there is
> some other exit condition which triggers once everything has been paged
> back in and actually causes the daemon to exit?
If the for() loop found nothing, then this triggers:
775 /* If no more pages to process, exit loop */
776 if ( i == paging->domain_info->max_pages )
777 break;
Olaf
next prev parent reply other threads:[~2011-06-24 14:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 12:16 [PATCH] tools: fix build after recent xenpaging changes Tim Deegan
2011-06-24 12:24 ` Olaf Hering
2011-06-24 12:33 ` Ian Campbell
2011-06-24 13:32 ` Olaf Hering
2011-06-24 13:48 ` Ian Campbell
2011-06-24 13:57 ` Olaf Hering
2011-06-24 14:30 ` Ian Campbell
2011-06-24 14:35 ` Olaf Hering [this message]
2011-06-24 14:41 ` Ian Campbell
2011-06-24 15:24 ` Olaf Hering
2011-06-27 13:50 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110624143511.GA30080@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Tim.Deegan@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.