From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaGXV-00006S-Tl for qemu-devel@nongnu.org; Fri, 24 Jun 2011 20:15:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QaGXU-00054O-Tv for qemu-devel@nongnu.org; Fri, 24 Jun 2011 20:15:57 -0400 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:22103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaGXU-000548-KI for qemu-devel@nongnu.org; Fri, 24 Jun 2011 20:15:56 -0400 From: Brad Hards Date: Sat, 25 Jun 2011 10:15:41 +1000 References: <1308943978-6152-1-git-send-email-hdegoede@redhat.com> <1308943978-6152-9-git-send-email-hdegoede@redhat.com> In-Reply-To: <1308943978-6152-9-git-send-email-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201106251015.42820.bradh@frogmouth.net> Subject: Re: [Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and PEDC port status bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org 5/11 does this: -#define PORTSC_RO_MASK 0x007021c5 +#define PORTSC_RO_MASK 0x007021c4 before 8/11 does this: > -#define PORTSC_RO_MASK 0x007021c4 > +#define PORTSC_RO_MASK 0x007021c0 You could push those together if there was a v2. I don't think its important though. Even nicer would be to build it out of symbolic constants / defines, so its obvious what is being masked. Brad