Re: [PATCH 14/14] OMAP2+: clockdomain: Add an api to read idle mode

[Todd Poynor <toddpoynor@google.com>]

On Fri, Jun 24, 2011 at 01:06:00PM +0200, Benoit Cousson wrote:
> From: Nayak, Rajendra <rnayak@ti.com>
> 
> Add a clockdomain api to check if hardware supervised
> idle transitions are enabled on a clockdomain.
> 
...
> + * clkdm_is_idle - Check if the clkdm hwsup/autoidle is enabled
> + * @clkdm: struct clockdomain *
> + *
> + * Returns true if the clockdomain is in hardware-supervised
> + * idle mode, or 0 otherwise.
> + *
> + */
> +int clkdm_is_idle(struct clockdomain *clkdm)
...
>  void clkdm_allow_idle(struct clockdomain *clkdm);
>  void clkdm_deny_idle(struct clockdomain *clkdm);
> +int clkdm_is_idle(struct clockdomain *clkdm);

Suggest the new API be named clkdm_allows_idle, since it tests that
hardware-supervised idle is allowed (perhaps via a call to
clkdm_allow_idle), and not that the clock domain is necessarily
idle at the time of call.


Todd