From: Oleg Nesterov <oleg@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
vda.linux@googlemail.com, jan.kratochvil@redhat.com,
pedro@codesourcery.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ptrace: ptrace_reparented() should check same_thread_group()
Date: Sun, 26 Jun 2011 23:08:23 +0200 [thread overview]
Message-ID: <20110626210823.GC16293@redhat.com> (raw)
In-Reply-To: <20110625134350.GU30101@htj.dyndns.org>
On 06/25, Tejun Heo wrote:
>
> This patch involves very subtle behavior change when the tracer is
> multi-threaded && real parent of the tracee. Slightly worrisome
Agreed. That is why, despite the fact the change itself is trivial,
the changelog is so long.
I am almost sure nobody will ever notice this change, but still this
is the user-visible change.
> but
> it is a bug fix and extremely fringe, so...
Agreed. Even if very minor, this looks like a bug, imho makes sense
to fix.
> Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
Oleg.
next prev parent reply other threads:[~2011-06-26 21:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 15:33 [PATCH 0/3] ptrace_reparented fixes/cleanups Oleg Nesterov
2011-06-24 15:34 ` [PATCH 1/3] ptrace: ptrace_reparented() should check same_thread_group() Oleg Nesterov
2011-06-25 13:43 ` Tejun Heo
2011-06-26 21:08 ` Oleg Nesterov [this message]
2011-06-24 15:34 ` [PATCH 2/3] ptrace: kill real_parent_is_ptracer() in in favor of ptrace_reparented() Oleg Nesterov
2011-06-25 13:49 ` Tejun Heo
2011-06-24 15:34 ` [PATCH 3/3] ptrace: wait_consider_task: s/same_thread_group/ptrace_reparented/ Oleg Nesterov
2011-06-25 13:52 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110626210823.GC16293@redhat.com \
--to=oleg@redhat.com \
--cc=jan.kratochvil@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pedro@codesourcery.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.