From: Arnd Bergmann <arnd@arndb.de>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] [media] v4l2 core: return -ENOIOCTLCMD if an ioctl doesn't exist
Date: Sun, 26 Jun 2011 21:52:52 +0200 [thread overview]
Message-ID: <201106262152.53096.arnd@arndb.de> (raw)
In-Reply-To: <4E077FB9.7030600@redhat.com>
On Sunday 26 June 2011 20:51:37 Mauro Carvalho Chehab wrote:
> >
> > I mean what do you return to vfs_ioctl from v4l? The conversions must
> > have been long before we introduced compat_ioctl and ENOIOCTLCMD.
> >
> > As far as I can tell, video_ioctl2 has always converted ENOIOCTLCMD into
> > EINVAL, so changing the vfs functions would not have any effect.
>
> Yes. This discussion was originated by a RFC patch proposing to change
> video_ioctl2 to return -ENOIOCTLCMD instead of -EINVAL.
Ok, I see. So returning -ENOIOCTLCMD is not an option IMHO, but if you
are confident that it doesn't break anything, returning -ENOTTY would
be possible and doesn't require any core changes.
Arnd
next prev parent reply other threads:[~2011-06-26 19:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 23:11 [PATCH] [media] v4l2 core: return -ENOIOCTLCMD if an ioctl doesn't exist Mauro Carvalho Chehab
2011-06-26 15:40 ` Sakari Ailus
2011-06-26 16:20 ` Mauro Carvalho Chehab
2011-06-26 17:13 ` Arnd Bergmann
2011-06-26 17:30 ` Mauro Carvalho Chehab
2011-06-26 18:20 ` Arnd Bergmann
2011-06-26 18:51 ` Mauro Carvalho Chehab
2011-06-26 19:52 ` Arnd Bergmann [this message]
2011-06-27 5:38 ` Hans Verkuil
2011-06-27 12:02 ` Sakari Ailus
2011-06-27 12:17 ` Hans Verkuil
2011-06-27 12:17 ` Hans Verkuil
2011-06-27 13:54 ` Mauro Carvalho Chehab
2011-06-27 14:56 ` Hans Verkuil
2011-06-27 15:33 ` Mauro Carvalho Chehab
2011-06-27 16:14 ` Arnd Bergmann
2011-06-27 16:42 ` Mauro Carvalho Chehab
2011-06-27 17:07 ` Hans Verkuil
2011-06-27 20:37 ` Mauro Carvalho Chehab
2011-06-27 20:48 ` Linus Torvalds
2011-06-28 6:04 ` Hans Verkuil
2011-06-28 16:05 ` Linus Torvalds
2011-06-28 16:42 ` Alan Cox
2011-06-28 16:50 ` Arnd Bergmann
2011-06-29 12:34 ` Mauro Carvalho Chehab
2011-06-27 15:12 ` Andy Walls
2011-06-27 15:12 ` Andy Walls
2011-06-27 15:24 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106262152.53096.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=sakari.ailus@iki.fi \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.