All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Denys Vlasenko <vda.linux@googlemail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptrace: make former thread ID available via PTRACE_GETEVENTMSG after PTRACE_EVENT_EXEC stop (v.2)
Date: Mon, 27 Jun 2011 15:47:13 +0200	[thread overview]
Message-ID: <20110627134713.GB3527@redhat.com> (raw)
In-Reply-To: <20110627081139.GY30101@htj.dyndns.org>

On 06/27, Tejun Heo wrote:
>
> Hello, Oleg, Denys.
>
> On Sun, Jun 26, 2011 at 10:04:42PM +0200, Oleg Nesterov wrote:
> > May be PT_TRACE_EXEC makes more sense. Note that
> > ptrace_event_enabled() was recently added.
>
> Do we want to enable this silently?  Wouldn't it be better to make it
> dependent on PT_SEIZED?

Hmm. Not sure I understand. Why can't PTRACE_SEIZE add PT_TRACE_EXEC
(and PT_TRACESYSGOOD) along with PT_SEIZED during attach?

I think this makes more sense, this way the tracer can disable this
later via PTRACE_SETOPTIONS if it wants. Not that I think this is really
useful but still. Otherwise we are going to silently disable
PTRACE_O_TRACEEXEC, this may be confusing.


But. If we want the PT_TRACE_EXEC behaviour for PT_SEIZED task (personally
I think we do), then we should probably record the old pid unconditionally,
the tracer can attach later.

Even in this case ptrace_event(PTRACE_EVENT_EXEC) can race with detach +
attach in theory, but I think in this case we do not care.

Oleg.


  reply	other threads:[~2011-06-27 13:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-26 19:08 [PATCH] ptrace: make former thread ID available via PTRACE_GETEVENTMSG after PTRACE_EVENT_EXEC stop (v.2) Denys Vlasenko
2011-06-26 20:04 ` Oleg Nesterov
2011-06-27  8:11   ` Tejun Heo
2011-06-27 13:47     ` Oleg Nesterov [this message]
2011-06-27 13:52       ` Tejun Heo
2011-06-27 15:18         ` Oleg Nesterov
2011-06-28  8:25           ` Tejun Heo
2011-06-28 12:30             ` Denys Vlasenko
2011-06-28 12:38               ` Tejun Heo
2011-06-28 16:35                 ` Oleg Nesterov
2011-06-28 16:49                   ` Tejun Heo
2011-06-28  0:31   ` Denys Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110627134713.GB3527@redhat.com \
    --to=oleg@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=vda.linux@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.