diff for duplicates of <20110627202135.GA12829@ericsson.com> diff --git a/a/1.txt b/N1/1.txt index 0324fb0..418230e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -300,7 +300,7 @@ and maybe consider renaming the function to lm95245_set_conversion_rate ? > + * Index 2 (Remote temp) has both signed and unsigned data > + * use signed calculation for remote if signed bit is set > + */ -> + if (index = 0 || data->temp[index] & 0x80) +> + if (index == 0 || data->temp[index] & 0x80) > + temp = TempFromRegSigned(data->temp[index], > + data->temp[index + 1]); > + else @@ -347,7 +347,7 @@ more than "crit" temperatures. > + > + val /= 1000; > + -> + val = SENSORS_LIMIT(val, 0, (index = 6 ? 127 : 256)); +> + val = SENSORS_LIMIT(val, 0, (index == 6 ? 127 : 256)); > + 256 -> 255 @@ -355,11 +355,11 @@ more than "crit" temperatures. > + > + data->valid = 0; > + -> + if (index = 6) +> + if (index == 6) > + /* local crit */ > + i2c_smbus_write_byte_data(client, > + LM95245_REG_RW_LOCAL_OS_TCRIT_LIMIT, val); -> + else if (index = 7) +> + else if (index == 7) > + /* remote crit */ > + i2c_smbus_write_byte_data(client, > + LM95245_REG_RW_REMOTE_TCRIT_LIMIT, val); @@ -428,7 +428,7 @@ Empty line between functions, please. > + > + mutex_lock(&data->update_lock); > + -> + if (val = 1) +> + if (val == 1) > + data->config2 |= CFG2_REMOTE_TT; > + else > + data->config2 &= ~CFG2_REMOTE_TT; @@ -557,11 +557,11 @@ temp2_crit_alarm > + return -ENODEV; > + > + if ((i2c_smbus_read_byte_data(new_client, LM95245_REG_R_MAN_ID) -> + = MANUFACTURER_ID) +> + == MANUFACTURER_ID) > + && (i2c_smbus_read_byte_data(new_client, LM95245_REG_R_CHIP_ID) > + >= DEFAULT_REVISION)) { -This should be =. We'll also have to change that for the LM95241 driver, +This should be ==. We'll also have to change that for the LM95241 driver, which accepts the LM95245 since it uses >= as well. Also, there is an unnecessary set of (). @@ -709,9 +709,4 @@ was done on purpose by the BIOS/ROMMON. I don't think you should override that. > +module_exit(sensors_lm95245_exit); > -- > 1.7.3.4 -> - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors +> diff --git a/a/content_digest b/N1/content_digest index c111604..e122c39 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\020110623153556.GG28311@ericsson.com\0" "ref\01309189749-7740-1-git-send-email-alexander.stein@systec-electronic.com\0" "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0" - "Subject\0Re: [lm-sensors] [PATCH v2] hwmon: LM95245 driver\0" - "Date\0Mon, 27 Jun 2011 20:21:35 +0000\0" + "Subject\0Re: [PATCH v2] hwmon: LM95245 driver\0" + "Date\0Mon, 27 Jun 2011 13:21:35 -0700\0" "To\0Alexander Stein <alexander.stein@systec-electronic.com>\0" "Cc\0Jean Delvare <khali@linux-fr.org>" lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org> @@ -311,7 +311,7 @@ "> + * Index 2 (Remote temp) has both signed and unsigned data\n" "> + * use signed calculation for remote if signed bit is set\n" "> + */\n" - "> + if (index = 0 || data->temp[index] & 0x80)\n" + "> + if (index == 0 || data->temp[index] & 0x80)\n" "> + temp = TempFromRegSigned(data->temp[index],\n" "> + data->temp[index + 1]);\n" "> + else\n" @@ -358,7 +358,7 @@ "> +\n" "> + val /= 1000;\n" "> +\n" - "> + val = SENSORS_LIMIT(val, 0, (index = 6 ? 127 : 256));\n" + "> + val = SENSORS_LIMIT(val, 0, (index == 6 ? 127 : 256));\n" "> +\n" "\t256 -> 255\n" "\n" @@ -366,11 +366,11 @@ "> +\n" "> + data->valid = 0;\n" "> +\n" - "> + if (index = 6)\n" + "> + if (index == 6)\n" "> + /* local crit */\n" "> + i2c_smbus_write_byte_data(client,\n" "> + LM95245_REG_RW_LOCAL_OS_TCRIT_LIMIT, val);\n" - "> + else if (index = 7)\n" + "> + else if (index == 7)\n" "> + /* remote crit */\n" "> + i2c_smbus_write_byte_data(client,\n" "> + LM95245_REG_RW_REMOTE_TCRIT_LIMIT, val);\n" @@ -439,7 +439,7 @@ "> +\n" "> + mutex_lock(&data->update_lock);\n" "> +\n" - "> + if (val = 1)\n" + "> + if (val == 1)\n" "> + data->config2 |= CFG2_REMOTE_TT;\n" "> + else\n" "> + data->config2 &= ~CFG2_REMOTE_TT;\n" @@ -568,11 +568,11 @@ "> + return -ENODEV;\n" "> +\n" "> + if ((i2c_smbus_read_byte_data(new_client, LM95245_REG_R_MAN_ID)\n" - "> + = MANUFACTURER_ID)\n" + "> + == MANUFACTURER_ID)\n" "> + && (i2c_smbus_read_byte_data(new_client, LM95245_REG_R_CHIP_ID)\n" "> + >= DEFAULT_REVISION)) {\n" "\n" - "This should be =. We'll also have to change that for the LM95241 driver,\n" + "This should be ==. We'll also have to change that for the LM95241 driver,\n" "which accepts the LM95245 since it uses >= as well. Also, there is an unnecessary\n" "set of ().\n" "\n" @@ -720,11 +720,6 @@ "> +module_exit(sensors_lm95245_exit);\n" "> --\n" "> 1.7.3.4\n" - "> \n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + > -0b484d10a3611d81dd581343b4147861bfe13e91986f389446ff3c30be441890 +9ae9ba13af797e5eb62832e08d1a1d2386823472f42366dd74bd6c541813cb80
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.