All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
To: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Cc: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] i2c-nomadik: fix kerneldoc warning
Date: Mon, 27 Jun 2011 23:04:49 +0100	[thread overview]
Message-ID: <20110627220449.GB23027@freya.fluff.org> (raw)
In-Reply-To: <1308134522-30858-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>

On Wed, Jun 15, 2011 at 12:42:02PM +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> 
> There was a missing struct item in the kerneldoc, add it and fix
> another pretty-printing formatting issue with a missing space.

weird, it didn't apply to 3.0-rc4.

i'll let the two things in one patch slide for this one.
 
> Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-nomadik.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
> index f9b8854..b228e09 100644
> --- a/drivers/i2c/busses/i2c-nomadik.c
> +++ b/drivers/i2c/busses/i2c-nomadik.c
> @@ -146,6 +146,7 @@ struct i2c_nmk_client {
>   * @stop: stop condition
>   * @xfer_complete: acknowledge completion for a I2C message
>   * @result: controller propogated result
> + * @regulator: pointer to i2c regulator
>   * @busy: Busy doing transfer
>   */
>  struct nmk_i2c_dev {
> @@ -509,7 +510,7 @@ static int write_i2c(struct nmk_i2c_dev *dev)
>  
>  	if (timeout < 0) {
>  		dev_err(&dev->pdev->dev,
> -			"wait_for_completion_timeout"
> +			"wait_for_completion_timeout "
>  			"returned %d waiting for event\n", timeout);
>  		status = timeout;
>  	}
> -- 
> 1.7.3.2
> 

  parent reply	other threads:[~2011-06-27 22:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15 10:42 [PATCH] i2c-nomadik: fix kerneldoc warning Linus Walleij
     [not found] ` <1308134522-30858-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2011-06-27 22:04   ` Ben Dooks [this message]
     [not found]     ` <20110627220449.GB23027-RazCHl0VsYgkUSuvROHNpA@public.gmane.org>
2011-06-28  5:25       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110627220449.GB23027@freya.fluff.org \
    --to=ben-i2c-elnmno+kys3ytjvyw6ydsg@public.gmane.org \
    --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org \
    --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.