From: Ted Ts'o <tytso@mit.edu>
To: amir73il@users.sourceforge.net
Cc: linux-ext4@vger.kernel.org, Amir Goldstein <amir73il@users.sf.net>
Subject: Re: [PATCH 3/4] ext4: clone indirect.c file from inode.c
Date: Mon, 27 Jun 2011 19:41:56 -0400 [thread overview]
Message-ID: <20110627234156.GG2729@thunk.org> (raw)
In-Reply-To: <1308649168-12543-4-git-send-email-amir73il@users.sourceforge.net>
On Tue, Jun 21, 2011 at 12:39:27PM +0300, amir73il@users.sourceforge.net wrote:
> From: Amir Goldstein <amir73il@users.sf.net>
>
> The next patch is going to move ext4_ind_ functions to
> indirect.c. First, we clone the file from inode.c and
> only leave code that is going to be duplicated in both files.
> This should keep the deleted lines count from inode.c in the next
> patch the same as the added lines count to indirect.c.
I really dislike cloning functions. This becomes a maintenance
headache, since bugs that get fixed in one file might not get
propagated to another. Since I need to manually move all of the
functions to verify nothing else changed in patches that do massive
code movement, I used the first two patches in your patch series, but
replaced the last two patches in the patch series, and replaced it
with the following:
A) Move __ext4_check_blockref() to fs/ext4/block_validity.c and
declare it extern.
B) Move ext4_truncate_failed_write() and blocks_for_truncate() to a
new function, fs/ext4/truncate.h.
C) Movement of indirect-related code to fs/ext4/indirect.c.
- Ted
next prev parent reply other threads:[~2011-06-27 23:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 9:39 [PATCH 0/4] ext4: reduce the size of inode.c amir73il
2011-06-21 9:39 ` [PATCH 1/4] ext4: split ext4_ind_truncate from ext4_truncate amir73il
2011-06-21 9:39 ` [PATCH 2/4] ext4: rename ext4_indirect_* funcs to ext4_ind_* amir73il
2011-06-21 9:39 ` [PATCH 3/4] ext4: clone indirect.c file from inode.c amir73il
2011-06-27 23:41 ` Ted Ts'o [this message]
2011-06-27 23:44 ` [PATCH 1/3] ext4: move __ext4_check_blockref to block_validity.c Theodore Ts'o
2011-06-27 23:44 ` [PATCH 2/3] ext4: move common truncate functions to header file Theodore Ts'o
2011-06-27 23:44 ` [PATCH 3/3] ext4: move ext4_ind_* functions from inode.c to indirect.c Theodore Ts'o
2011-06-28 7:02 ` [PATCH 3/4] ext4: clone indirect.c file from inode.c Amir G.
2011-06-21 9:39 ` [PATCH 4/4] ext4: move ext4_ind_* functions from inode.c to indirect.c amir73il
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110627234156.GG2729@thunk.org \
--to=tytso@mit.edu \
--cc=amir73il@users.sf.net \
--cc=amir73il@users.sourceforge.net \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.