diff for duplicates of <20110628144303.GA29554@ericsson.com> diff --git a/a/1.txt b/N1/1.txt index 81dd550..322e3e1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -35,7 +35,7 @@ Only nitpicks this time around. > +++ b/Documentation/hwmon/lm95245 > @@ -0,0 +1,33 @@ > +Kernel driver lm95245 -> +========= +> +================== > + > +Supported chips: > + * National Semiconductor LM95245 @@ -318,7 +318,7 @@ I keep forgetting this ... the above function names violate CodingStyle, chapter > + * Index 2 (Remote temp) has both signed and unsigned data > + * use signed calculation for remote if signed bit is set > + */ -> + if (index = 0 || data->regs[index] & 0x80) +> + if (index == 0 || data->regs[index] & 0x80) > + temp = TempFromRegSigned(data->regs[index], > + data->regs[index + 1]); > + else @@ -351,7 +351,7 @@ I keep forgetting this ... the above function names violate CodingStyle, chapter > + > + val /= 1000; > + -> + val = SENSORS_LIMIT(val, 0, (index = 6 ? 127 : 255)); +> + val = SENSORS_LIMIT(val, 0, (index == 6 ? 127 : 255)); > + > + mutex_lock(&data->update_lock); > + @@ -415,7 +415,7 @@ I keep forgetting this ... the above function names violate CodingStyle, chapter > + > + mutex_lock(&data->update_lock); > + -> + if (val = 1) +> + if (val == 1) > + data->config2 |= CFG2_REMOTE_TT; > + else > + data->config2 &= ~CFG2_REMOTE_TT; @@ -656,9 +656,4 @@ In other words, you don't need it if you read the conversion interval above. > +module_exit(sensors_lm95245_exit); > -- > 1.7.3.4 -> - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors +> diff --git a/a/content_digest b/N1/content_digest index c57a3b2..d7a9634 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\020110627202135.GA12829@ericsson.com\0" "ref\01309244829-12304-1-git-send-email-alexander.stein@systec-electronic.com\0" "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0" - "Subject\0Re: [lm-sensors] [PATCH v3] hwmon: LM95245 driver\0" - "Date\0Tue, 28 Jun 2011 14:43:03 +0000\0" + "Subject\0Re: [PATCH v3] hwmon: LM95245 driver\0" + "Date\0Tue, 28 Jun 2011 07:43:03 -0700\0" "To\0Alexander Stein <alexander.stein@systec-electronic.com>\0" "Cc\0Jean Delvare <khali@linux-fr.org>" lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org> @@ -46,7 +46,7 @@ "> +++ b/Documentation/hwmon/lm95245\n" "> @@ -0,0 +1,33 @@\n" "> +Kernel driver lm95245\n" - "> +=========\n" + "> +==================\n" "> +\n" "> +Supported chips:\n" "> + * National Semiconductor LM95245\n" @@ -329,7 +329,7 @@ "> + * Index 2 (Remote temp) has both signed and unsigned data\n" "> + * use signed calculation for remote if signed bit is set\n" "> + */\n" - "> + if (index = 0 || data->regs[index] & 0x80)\n" + "> + if (index == 0 || data->regs[index] & 0x80)\n" "> + temp = TempFromRegSigned(data->regs[index],\n" "> + data->regs[index + 1]);\n" "> + else\n" @@ -362,7 +362,7 @@ "> +\n" "> + val /= 1000;\n" "> +\n" - "> + val = SENSORS_LIMIT(val, 0, (index = 6 ? 127 : 255));\n" + "> + val = SENSORS_LIMIT(val, 0, (index == 6 ? 127 : 255));\n" "> +\n" "> + mutex_lock(&data->update_lock);\n" "> +\n" @@ -426,7 +426,7 @@ "> +\n" "> + mutex_lock(&data->update_lock);\n" "> +\n" - "> + if (val = 1)\n" + "> + if (val == 1)\n" "> + data->config2 |= CFG2_REMOTE_TT;\n" "> + else\n" "> + data->config2 &= ~CFG2_REMOTE_TT;\n" @@ -667,11 +667,6 @@ "> +module_exit(sensors_lm95245_exit);\n" "> --\n" "> 1.7.3.4\n" - "> \n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + > -67f5d43f73b79debb3b825162d53689950a7e0b9f51e99f431a08ad825eee3e5 +1b21b85be1fe1c8747c536cb19b16a56118de7a7255ca6895610138831fa1d97
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.