From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbqzV-00081l-6T for qemu-devel@nongnu.org; Wed, 29 Jun 2011 05:23:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbqzT-0006Lc-Kr for qemu-devel@nongnu.org; Wed, 29 Jun 2011 05:23:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54214) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbqzS-0006LX-VV for qemu-devel@nongnu.org; Wed, 29 Jun 2011 05:23:23 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5T9NMX9013064 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jun 2011 05:23:22 -0400 Date: Wed, 29 Jun 2011 11:23:09 +0200 From: Alon Levy Message-ID: <20110629092309.GM30873@bow.redhat.com> References: <1308920577-31569-1-git-send-email-alevy@redhat.com> <1308920577-31569-13-git-send-email-alevy@redhat.com> <4E083476.2030509@redhat.com> <20110627082126.GO2731@bow.redhat.com> <4E0AE547.7080602@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E0AE547.7080602@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qxl: add primary_created state, change mode lifetimes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: yhalperi , qemu-devel@nongnu.org On Wed, Jun 29, 2011 at 10:41:43AM +0200, Gerd Hoffmann wrote: > Hi, > > >>Shouldn't the mode change to QXL_MODE_UNDEFINED on DESTROY_SURFACES? > >>(I can see it currently doesn't, but it seems like a mistake) > > > >No, that is the point - this patch makes the lifetime of QXL_MODE_NATIVE be > >the lifetime of the driver in the guest, kinda. we never unload the driver > >in the guest, the only time it stops being operational is when we enter vga > >mode and that's explicitly done when we get any vga port write/read. > > I agree with yonit here, moving to UNDEFINED makes sense. Keeping > track of guest driver state in qxl is asking for trouble. It will > blow up when it comes to S4 support and we'll exit and restart the > qemu process. Actually S4 support == S3 support. There is absolutely no difference. Since qemu still does a reset. But I already checked dropping this patch and using UNDEFINED instead and it works fine. I just had to additionally allow io when in UNDEFINED. I think that makes sense, since UNDEFINED is just the same as "driver working but primary destroyed". > > cheers, > Gerd > >