All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andres Salomon <dilinger@queued.net>
To: Philip Prindeville <philipp@redfish-solutions.com>
Cc: linux-geode@lists.infradead.org, alex@ozo.com,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/1] geode: Reflect mfgpt dependency on mfd.
Date: Wed, 29 Jun 2011 09:56:49 -0700	[thread overview]
Message-ID: <20110629095649.06ee4d09@queued.net> (raw)
In-Reply-To: <1309320009-26092-1-git-send-email-philipp@redfish-solutions.com>

Looks correct to me.  It should probably be sent to Andrew to be queued
up.

Acked-by: Andres Salomon <dilinger@queued.net>

On Tue, 28 Jun 2011
22:00:09 -0600 Philip Prindeville <philipp@redfish-solutions.com> wrote:

> From: Philip A. Prindeville <philipp@redfish-solutions.com>
> 
> As stated in drivers/mfd/cs5535-mfd.c, the mfd driver exposes the BARs
> which then make the GPIO, MFGPT, ACPI, etc. all visible to the system.
> 
> This dependency needs to be reflected in Kconfig.
> 
> Signed-off-by: Philip A. Prindeville <philipp@redfish-solutions.com>
> Acked-by: Alexandros C. Couloumbis <alex@ozo.com>
> ---
>  drivers/misc/Kconfig |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 4e349cd..3546474 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -245,8 +245,7 @@ config SGI_XP
>  
>  config CS5535_MFGPT
>  	tristate "CS5535/CS5536 Geode Multi-Function General Purpose
> Timer (MFGPT) support"
> -	depends on PCI
> -	depends on X86
> +	depends on PCI && X86 && MFD_CS5535
>  	default n
>  	help
>  	  This driver provides access to MFGPT functionality for
> other

           reply	other threads:[~2011-06-29 17:05 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1309320009-26092-1-git-send-email-philipp@redfish-solutions.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110629095649.06ee4d09@queued.net \
    --to=dilinger@queued.net \
    --cc=akpm@linux-foundation.org \
    --cc=alex@ozo.com \
    --cc=linux-geode@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp@redfish-solutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.