From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbtBH-0000qI-IT for qemu-devel@nongnu.org; Wed, 29 Jun 2011 07:43:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbtBE-0004Jb-IK for qemu-devel@nongnu.org; Wed, 29 Jun 2011 07:43:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbtBE-0004JG-0A for qemu-devel@nongnu.org; Wed, 29 Jun 2011 07:43:40 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5TBhcZP010083 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Jun 2011 07:43:39 -0400 Date: Wed, 29 Jun 2011 13:43:26 +0200 From: Alon Levy Message-ID: <20110629114326.GT30873@bow.redhat.com> References: <1308920577-31569-1-git-send-email-alevy@redhat.com> <1308920577-31569-5-git-send-email-alevy@redhat.com> <4E0AEEBD.9000002@redhat.com> <20110629093122.GP30873@bow.redhat.com> <4E0AF836.3030507@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E0AF836.3030507@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] qxl: allow QXL_IO_LOG also in vga List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: yhalperi@redhat.com, qemu-devel@nongnu.org On Wed, Jun 29, 2011 at 12:02:30PM +0200, Gerd Hoffmann wrote: > Hi, > > >Yeah, my bad. I did something wierd, and missed this. I'll send a v3. Do you have other comments? > > I stopped looking after figuring stuff doesn't apply to master. > > >Unrelated, but have you looked at the async patches that I sent, and yonit's comments? > > - (me) catch EINTR and EAGAIN in async thread read > > - (yonit) reset surfaces count and surfaces when doing destroy_all > > http://cgit.freedesktop.org/spice/qemu/log/?h=bz700134 is what I > currently have. Some of your patches are in there already. I tried rebasing on that, testing showed there was a deadlock, you can't reuse wlock for track_command since it is called from interface_get_command, called from red_worker, which may be during update_area, which already took the wlock. Adding a separate track_lock will probably work. > > cheers, > Gerd >