From: Olaf Hering <olaf@aepfle.de>
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH 1 of 5] Nested p2m: implement "flush" as a first-class action
Date: Thu, 30 Jun 2011 11:51:05 +0200 [thread overview]
Message-ID: <20110630095105.GA9431@aepfle.de> (raw)
In-Reply-To: <44c7b977302663487922.1309171571@whitby.uk.xensource.com>
On Mon, Jun 27, Tim Deegan wrote:
> diff -r b24018319772 -r 44c7b9773026 xen/arch/x86/mm/p2m.c
> --- a/xen/arch/x86/mm/p2m.c Thu Jun 23 18:34:55 2011 +0100
> +++ b/xen/arch/x86/mm/p2m.c Fri Jun 24 16:24:44 2011 +0100
> @@ -1050,20 +1050,41 @@ p2m_getlru_nestedp2m(struct domain *d, s
> return lrup2m;
> }
>
> -static int
> +/* Reset this p2m table to be empty */
> +static void
> p2m_flush_locked(struct p2m_domain *p2m)
> {
> - ASSERT(p2m);
> - if (p2m->cr3 == CR3_EADDR)
> - /* Microoptimisation: p2m is already empty.
> - * => about 0.3% speedup of overall system performance.
> - */
> - return 0;
> + struct page_info *top, *pg;
> + struct domain *d = p2m->domain;
Tim,
one of these changes causes a build error:
p2m.c:1105:20: error: unused variable 'd' [-Werror=unused-variable]
Olaf
next prev parent reply other threads:[~2011-06-30 9:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 10:46 [PATCH 0 of 5] v2: Nested-p2m cleanups and locking changes Tim Deegan
2011-06-27 10:46 ` [PATCH 1 of 5] Nested p2m: implement "flush" as a first-class action Tim Deegan
2011-06-30 9:51 ` Olaf Hering [this message]
2011-06-30 10:02 ` Tim Deegan
2011-06-27 10:46 ` [PATCH 2 of 5] Nested p2m: remove bogus check of CR3 value Tim Deegan
2011-06-27 10:46 ` [PATCH 3 of 5] Nested p2m: clarify logic in p2m_get_nestedp2m() Tim Deegan
2011-06-27 10:46 ` [PATCH 4 of 5] Nested p2m: flush only one p2m table when reallocating Tim Deegan
2011-06-27 13:44 ` Christoph Egger
2011-06-27 14:01 ` Tim Deegan
2011-06-27 10:46 ` [PATCH 5 of 5] Nested p2m: rework locking around nested-p2m flushes and updates Tim Deegan
2011-06-27 10:56 ` [PATCH 0 of 5] v2: Nested-p2m cleanups and locking changes Tim Deegan
2011-06-27 12:23 ` Christoph Egger
2011-06-27 13:15 ` Tim Deegan
2011-06-27 13:20 ` Tim Deegan
2011-06-27 13:24 ` Christoph Egger
2011-06-27 13:55 ` Tim Deegan
2011-06-27 15:48 ` Tim Deegan
2011-06-28 11:04 ` Christoph Egger
2011-06-28 13:47 ` Christoph Egger
2011-06-30 9:49 ` Tim Deegan
2011-07-01 10:00 ` Christoph Egger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630095105.GA9431@aepfle.de \
--to=olaf@aepfle.de \
--cc=Christoph.Egger@amd.com \
--cc=Tim.Deegan@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.