From: simon@sequanux.org (Simon Guinot)
To: linux-arm-kernel@lists.infradead.org
Subject: plat-orion gpio regression for edge-sensitive on mv78xx0
Date: Thu, 30 Jun 2011 09:52:23 +0000 [thread overview]
Message-ID: <20110630095223.GH31228@kw.sim.vm.gnt> (raw)
In-Reply-To: <4E0B8492.2030201@drewtech.com>
Hi,
On Wed, Jun 29, 2011 at 04:01:22PM -0400, Joey Oravec wrote:
> Nicolas, Lennert -
>
> I just tested linux kernel 3.0-rc5 today. There were some major
> changes to arch/arm/plat-orion/gpio.c and I think they introduced a
> bug for edge sensitive interrupts. I have not tested any other types
> yet. This new version of the code specifies
As level interrupts don't need to be acked, it should be ok.
>
> ct->chip.irq_ack = irq_gc_ack;
>
> But it looks like kernel/irq/generic-chip.c generates a positive
> mask (1 to clear) and the MV78200 wants the opposite (0 to clear).
> The result is that the interrupt never gets ACKed and the handler
> will keep getting called.
Maybe we could introduce some irq_gc_ack{_set_bit,_clear_bit}
variants (as for the mask functions) ?
As an another option, we could define an Orion specific irq_ack
function.
I don't know what is the better choice for rc5.
Regards,
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110630/b77176e8/attachment.sig>
next prev parent reply other threads:[~2011-06-30 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 20:01 plat-orion gpio regression for edge-sensitive on mv78xx0 Joey Oravec
2011-06-30 9:52 ` Simon Guinot [this message]
2011-06-30 21:39 ` [PATCH] genirq: replace irq_gc_ack with {set,clr}_bit variants Simon Guinot
2011-07-02 12:35 ` Simon Guinot
2011-07-03 8:41 ` saeed bishara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630095223.GH31228@kw.sim.vm.gnt \
--to=simon@sequanux.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.