From: Ondrej Zary <linux@rainbow-software.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-media@vger.kernel.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] media: fix radio-sf16fmr2 build when SND is not enabled
Date: Thu, 30 Jun 2011 20:36:49 +0200 [thread overview]
Message-ID: <201106302036.56468.linux@rainbow-software.org> (raw)
In-Reply-To: <20110630103104.0a5b8ce6.randy.dunlap@oracle.com>
On Thursday 30 June 2011 19:31:04 Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> When CONFIG_SND is not enabled, radio-sf16fmr2 build fails with:
>
> ERROR: "snd_tea575x_init" [drivers/media/radio/radio-sf16fmr2.ko] undefined!
> ERROR: "snd_tea575x_exit" [drivers/media/radio/radio-sf16fmr2.ko] undefined!
>
> so make this driver depend on SND.
I broke this when converting the driver to use common TEA575x code.
Thanks for finding and fixing it.
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
> Cc: linux-media@vger.kernel.org
> ---
> drivers/media/radio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20110630.orig/drivers/media/radio/Kconfig
> +++ linux-next-20110630/drivers/media/radio/Kconfig
> @@ -201,7 +201,7 @@ config RADIO_SF16FMI
>
> config RADIO_SF16FMR2
> tristate "SF16FMR2 Radio"
> - depends on ISA && VIDEO_V4L2
> + depends on ISA && VIDEO_V4L2 && SND
> ---help---
> Choose Y here if you have one of these FM radio cards.
--
Ondrej Zary
prev parent reply other threads:[~2011-06-30 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 6:53 linux-next: Tree for June 30 Stephen Rothwell
2011-06-30 17:31 ` [PATCH] media: fix radio-sf16fmr2 build when SND is not enabled Randy Dunlap
2011-06-30 18:36 ` Ondrej Zary [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106302036.56468.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.