From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Mat Martineau <mathewm@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/6] Bluetooth: Check earlier for L2CAP ERTM frames to drop
Date: Thu, 30 Jun 2011 18:24:19 -0300 [thread overview]
Message-ID: <20110630212419.GF25602@joana> (raw)
In-Reply-To: <1309383324-12002-2-git-send-email-mathewm@codeaurora.org>
* Mat Martineau <mathewm@codeaurora.org> [2011-06-29 14:35:19 -0700]:
> Even when the received tx_seq is expected, the frame still needs to be
> dropped if the TX window is exceeded or the receiver is in the local
> busy state.
The check doesn't mean that TX window is exceeded, it means that we have an
invalid tx_seq and connection should be closed. I don't see the point in
moving the expected check to after this one.
About the local busy check. Is it worth to drop expected frames when on local
busy? What are the advantages/disadvantages? Drop will trigger SREJ while
Store will press the buffer. Do you have measures to prove this?
Gustavo
next prev parent reply other threads:[~2011-06-30 21:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 21:35 [PATCH 0/6] Bluetooth: ERTM fixes and local busy enhancement Mat Martineau
2011-06-29 21:35 ` [PATCH 1/6] Bluetooth: Check earlier for L2CAP ERTM frames to drop Mat Martineau
2011-06-30 21:24 ` Gustavo F. Padovan [this message]
2011-06-30 23:36 ` Mat Martineau
2011-07-01 19:13 ` Gustavo F. Padovan
2011-07-05 17:45 ` Mat Martineau
2011-06-29 21:35 ` [PATCH 2/6] Bluetooth: Fix indentation whitespace Mat Martineau
2011-06-30 21:29 ` Gustavo F. Padovan
2011-06-29 21:35 ` [PATCH 3/6] Bluetooth: ERTM timeouts need to be converted to jiffies Mat Martineau
2011-06-30 21:27 ` Gustavo F. Padovan
2011-06-29 21:35 ` [PATCH 4/6] Bluetooth: Move code for ERTM local busy state to separate functions Mat Martineau
2011-06-29 21:35 ` [PATCH 5/6] Bluetooth: Use event-driven approach for handling ERTM receive buffer Mat Martineau
2011-06-30 21:40 ` Gustavo F. Padovan
2011-07-01 17:29 ` Mat Martineau
2011-07-06 15:49 ` Gustavo Padovan
2011-06-29 21:35 ` [PATCH 6/6] Bluetooth: Remove L2CAP busy queue Mat Martineau
2011-06-30 21:42 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630212419.GF25602@joana \
--to=padovan@profusion.mobi \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mathewm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.