From: Tony Lindgren <tony@atomide.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org, Felipe Balbi <balbi@ti.com>,
Jarkko Nikula <jhnikula@gmail.com>,
"Varadarajan, Charulatha" <charu@ti.com>
Subject: Re: [RESEND] [PATCH 3.0] OMAP: drop __initdata tags from static struct platform_device declarations
Date: Fri, 1 Jul 2011 00:12:27 -0700 [thread overview]
Message-ID: <20110701071227.GA23145@atomide.com> (raw)
In-Reply-To: <201106170318.32326.jkrzyszt@tis.icnet.pl>
* Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [110616 18:15]:
> Pointers to statically declared platform device structures which are
> registered with platform_device_register() are then used during run time
> to access these structure members, for example from platform_uevent()
> and much more. Therefore, these structures should never be placed inside
> sections which are dropped after boot. Fix platform devices incorrectly
> tagged with __initdata which happen to exist inside OMAP sub-trees.
>
> This bug has exhibited itself on my ARM/OMAP1 based Amstrad Delta
> videophone after commit 6d3163ce86dd386b4f7bda80241d7fea2bc0bb1d, "mm:
> check if any page in a pageblock is reserved before marking it
> MIGRATE_RESERVE", resulting in reading from several
> /sys/device/platform/*/uevent files always ending up with segmentation
> faults.
Thanks applying into devel-fixes.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND] [PATCH 3.0] OMAP: drop __initdata tags from static struct platform_device declarations
Date: Fri, 1 Jul 2011 00:12:27 -0700 [thread overview]
Message-ID: <20110701071227.GA23145@atomide.com> (raw)
In-Reply-To: <201106170318.32326.jkrzyszt@tis.icnet.pl>
* Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [110616 18:15]:
> Pointers to statically declared platform device structures which are
> registered with platform_device_register() are then used during run time
> to access these structure members, for example from platform_uevent()
> and much more. Therefore, these structures should never be placed inside
> sections which are dropped after boot. Fix platform devices incorrectly
> tagged with __initdata which happen to exist inside OMAP sub-trees.
>
> This bug has exhibited itself on my ARM/OMAP1 based Amstrad Delta
> videophone after commit 6d3163ce86dd386b4f7bda80241d7fea2bc0bb1d, "mm:
> check if any page in a pageblock is reserved before marking it
> MIGRATE_RESERVE", resulting in reading from several
> /sys/device/platform/*/uevent files always ending up with segmentation
> faults.
Thanks applying into devel-fixes.
Tony
next prev parent reply other threads:[~2011-07-01 7:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 22:02 [PATCH 3.0] OMAP: drop __initdata tags from static struct platform_device declarations Janusz Krzysztofik
2011-06-16 22:02 ` Janusz Krzysztofik
2011-06-16 22:18 ` Russell King - ARM Linux
2011-06-16 22:18 ` Russell King - ARM Linux
2011-06-17 1:18 ` [RESEND] " Janusz Krzysztofik
2011-06-17 1:18 ` Janusz Krzysztofik
2011-07-01 7:12 ` Tony Lindgren [this message]
2011-07-01 7:12 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701071227.GA23145@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=charu@ti.com \
--cc=jhnikula@gmail.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.