All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Rees <rees@umich.edu>
To: Luk Claes <luk@debian.org>
Cc: NeilBrown <neilb@suse.de>, Steve Dickson <SteveD@redhat.com>,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH] Do not segfault because of kernel version
Date: Sun, 3 Jul 2011 09:02:37 -0400	[thread overview]
Message-ID: <20110703130237.GA9889@merit.edu> (raw)
In-Reply-To: <4E100E17.5000304@debian.org>

Luk Claes wrote:

  > So if the version number is not recognised - e.g. it was written in Sanskrit
  > rather than arabic numberals, it is assumed to be a future version, not a
  > past version.
  > 
  >  https://lkml.org/lkml/2011/6/14/293
  
  Ah, not a bad idea. In that case a parse error can be distinguished from
  other errors. Would 'return -1' do the expected or will it give a
  compiler warning/error we should avoid?

You can't return -1 from a function returning unsigned int.  I think you
want to return something like

MAKE_VERSION(9999, 255, 255)

  reply	other threads:[~2011-07-03 13:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-02 14:32 [PATCH] Do not segfault because of kernel version Luk Claes
2011-07-03  5:04 ` NeilBrown
2011-07-03  6:37   ` Luk Claes
2011-07-03 13:02     ` Jim Rees [this message]
2011-07-03 13:10       ` Luk Claes
2011-07-03 13:26         ` Jim Rees
2011-07-03 13:28           ` Luk Claes
2011-07-03 14:11             ` Jim Rees
2011-07-04 16:28               ` Luk Claes
2011-07-04 19:00                 ` Jim Rees
2011-07-05  5:42                   ` Luk Claes
2011-07-05  5:42                     ` Luk Claes
2011-07-12 14:42                       ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110703130237.GA9889@merit.edu \
    --to=rees@umich.edu \
    --cc=SteveD@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=luk@debian.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.