From: Harry Wei <jiaweiwei.xiyou@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: amwang@redhat.com, linux-kernel@vger.kernel.org,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] netpoll: Remove unused EXPORT_SYMBOLs of netpoll_poll and netpoll_poll_dev
Date: Mon, 4 Jul 2011 17:27:38 +0800 [thread overview]
Message-ID: <20110704092736.GA2932@gmail.com> (raw)
In-Reply-To: <1309765589.18925.42.camel@Joe-Laptop>
On Mon, Jul 04, 2011 at 12:46:29AM -0700, Joe Perches wrote:
[...]
> > You have removed the function declaration in include/linux/netpoll.h.
>
> Because it's unused by anything in the tree
> but netpoll.c
Hmmmm..., so sorry. I misunderstood your 'unused', which i thought
there was also no use in netpoll.c :-/
>
> > And you changed the function like
> > static void netpoll_poll_dev(...)
> > {
> > ...
> > }
> > But i don't know its usage.
>
> It's now a local function to netpoll.c
Yeah, it's true.
>
> > The 'static' before this function just says the active area of 'netpoll_poll_dev'
> > is in the file net/core/netpoll.c. What is the purpose? Could you please tell me?
>
> It prods the device to perform network work.
>
> /* Process pending work on NIC */
> ops->ndo_poll_controller(dev);
>
> poll_napi(dev);
Yeah, i will read the codes.
Thanks so much
Harry Wei
next prev parent reply other threads:[~2011-07-04 9:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 1:08 [PATCH 0/2] netpoll: Trivial updates Joe Perches
2011-07-01 1:08 ` [PATCH 1/2] netpoll: Remove unused EXPORT_SYMBOLs of netpoll_poll and netpoll_poll_dev Joe Perches
2011-07-04 3:02 ` David Miller
2011-07-04 6:53 ` Harry Wei
2011-07-04 7:46 ` Joe Perches
2011-07-04 9:27 ` Harry Wei [this message]
2011-07-01 1:08 ` [PATCH 2/2] netpoll: Remove wrapper function netpoll_poll Joe Perches
2011-07-04 3:02 ` David Miller
2011-07-01 3:26 ` [PATCH 0/2] netpoll: Trivial updates Cong Wang
2011-07-01 3:35 ` Joe Perches
2011-07-01 3:49 ` Cong Wang
2011-07-01 3:55 ` Joe Perches
2011-07-01 4:00 ` Cong Wang
2011-07-01 4:03 ` Joe Perches
2011-07-01 4:05 ` Cong Wang
2011-07-01 7:06 ` David Miller
2011-07-01 22:18 ` Joe Perches
2011-07-01 22:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704092736.GA2932@gmail.com \
--to=jiaweiwei.xiyou@gmail.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.