From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Supriya Kannery <supriyak@linux.vnet.ibm.com>,
Christoph Hellwig <hch@lst.de>
Subject: [Qemu-devel] [V4 Patch 1/4]Qemu: Enhance "info block" to display host cache setting
Date: Mon, 04 Jul 2011 16:12:51 +0530 [thread overview]
Message-ID: <20110704104251.28170.3263.sendpatchset@skannery> (raw)
In-Reply-To: <20110704104237.28170.97021.sendpatchset@skannery>
Enhance "info block" to display hostcache setting for each
block device.
Example:
(qemu) info block
ide0-hd0: type=hd removable=0 file=../rhel6-32.qcow2 ro=0 drv=qcow2
encrypted=0
Enhanced to display "hostcache" setting:
(qemu) info block
ide0-hd0: type=hd removable=0 hostcache=true file=../rhel6-32.qcow2
ro=0 drv=qcow2 encrypted=0
Signed-off-by: Supriya Kannery <supriyak@in.ibm.com>
---
block.c | 21 +++++++++++++++++----
qmp-commands.hx | 2 ++
2 files changed, 19 insertions(+), 4 deletions(-)
Index: qemu/block.c
===================================================================
--- qemu.orig/block.c
+++ qemu/block.c
@@ -1694,6 +1694,14 @@ static void bdrv_print_dict(QObject *obj
monitor_printf(mon, " locked=%d", qdict_get_bool(bs_dict, "locked"));
}
+ if (qdict_haskey(bs_dict, "open_flags")) {
+ int open_flags = qdict_get_int(bs_dict, "open_flags");
+ if (open_flags & BDRV_O_NOCACHE)
+ monitor_printf(mon, " hostcache=false");
+ else
+ monitor_printf(mon, " hostcache=true");
+ }
+
if (qdict_haskey(bs_dict, "inserted")) {
QDict *qdict = qobject_to_qdict(qdict_get(bs_dict, "inserted"));
@@ -1730,13 +1738,18 @@ void bdrv_info(Monitor *mon, QObject **r
QObject *bs_obj;
bs_obj = qobject_from_jsonf("{ 'device': %s, 'type': 'unknown', "
- "'removable': %i, 'locked': %i }",
- bs->device_name, bs->removable,
- bs->locked);
+ "'removable': %i, 'locked': %i, "
+ "'hostcache': %s }",
+ bs->device_name, bs->removable,
+ bs->locked,
+ (bs->open_flags & BDRV_O_NOCACHE) ?
+ "false" : "true");
+
+ QDict *bs_dict = qobject_to_qdict(bs_obj);
+ qdict_put(bs_dict, "open_flags", qint_from_int(bs->open_flags));
if (bs->drv) {
QObject *obj;
- QDict *bs_dict = qobject_to_qdict(bs_obj);
obj = qobject_from_jsonf("{ 'file': %s, 'ro': %i, 'drv': %s, "
"'encrypted': %i }",
Index: qemu/qmp-commands.hx
===================================================================
--- qemu.orig/qmp-commands.hx
+++ qemu/qmp-commands.hx
@@ -1070,6 +1070,7 @@ Each json-object contain the following:
- Possible values: "unknown"
- "removable": true if the device is removable, false otherwise (json-bool)
- "locked": true if the device is locked, false otherwise (json-bool)
+- "hostcache": true if hostcache enabled, false otherwise (json-bool)
- "inserted": only present if the device is inserted, it is a json-object
containing the following:
- "file": device file name (json-string)
@@ -1091,6 +1092,7 @@ Example:
{
"device":"ide0-hd0",
"locked":false,
+ "hostcache":false,
"removable":false,
"inserted":{
"ro":false,
next prev parent reply other threads:[~2011-07-04 10:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 10:42 [Qemu-devel] [V4 Patch 0/4]Qemu: Hostcache setting from cmdline and monitor Supriya Kannery
2011-07-04 10:42 ` Supriya Kannery [this message]
2011-07-04 11:54 ` [Qemu-devel] [V4 Patch 1/4]Qemu: Enhance "info block" to display host cache setting Stefan Hajnoczi
2011-07-05 10:49 ` [Qemu-devel] [V4 Patch 1/4 -Updated]Qemu: " Supriya Kannery
2011-07-20 7:37 ` Supriya Kannery
2011-07-04 10:43 ` [Qemu-devel] [V4 Patch 2/4]Qemu: Error classes for file reopen and data sync failure Supriya Kannery
2011-07-04 10:43 ` [Qemu-devel] [V4 Patch 3/4]Qemu: Command "block_set" for dynamic block params change Supriya Kannery
2011-07-04 12:29 ` Stefan Hajnoczi
2011-07-05 10:55 ` Supriya Kannery
2011-07-13 13:07 ` [Qemu-devel] [V4 Patch 3/4 - Updated]Qemu: " Supriya Kannery
2011-07-20 7:38 ` Supriya Kannery
2011-07-25 6:30 ` Stefan Hajnoczi
2011-07-25 12:52 ` Supriya Kannery
2011-07-25 12:50 ` Stefan Hajnoczi
2011-07-25 13:34 ` Kevin Wolf
2011-07-26 5:47 ` Supriya Kannery
2011-07-04 12:35 ` [Qemu-devel] [V4 Patch 3/4]Qemu: " Stefan Hajnoczi
2011-07-04 10:43 ` [Qemu-devel] [V4 Patch 4/4]Qemu: Add commandline -drive option 'hostcache' Supriya Kannery
2011-07-04 12:31 ` Stefan Hajnoczi
2011-07-05 11:05 ` [Qemu-devel] [V4 Patch 4/4 - Updated]Qemu: " Supriya Kannery
2011-07-20 7:39 ` Supriya Kannery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704104251.28170.3263.sendpatchset@skannery \
--to=supriyak@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.